Re: [PATCH v3 1/2] arm: dts: gta04: add ldo 3v3 regulator

Johan Hovold
2019-02-01T10:02:44Z

On Thu, Jan 31, 2019 at 07:06:39PM +0100, Andreas Kemnade wrote:
> Required for completeness sake to be able to specify
> a regulator for devices having a non-optional regulator
> property. It corresponds to the "3V3" net in the
> schematics.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> new in v3
>
> arch/arm/boot/dts/omap3-gta04.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> index e53d32691308..02d8274a2f47 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -32,6 +32,14 @@
> display1 = &tv0;
> };
>
> + ldo_3v3: fixedregulator {

A suffix, even if its just to rename as "fixedregulator0", would allow
further fixed regulators to be added later, but I guess that can be
handled then.

> + compatible = "regulator-fixed";
> + regulator-name = "ldo_3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> /* fixed 26MHz oscillator */
> hfclk_26m: oscillator {
> #clock-cells = <0>;

Reviewed-by: Johan Hovold <johan@kernel.org>

Johan