From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: tony@atomide.com
Cc: devicetree@vger.kernel.org, grygorii.strashko@ti.com,
marc.w.gonzalez@free.fr, netdev@vger.kernel.org, nsekhar@ti.com,
vkoul@kernel.org, f.fainelli@gmail.com, bcousson@baylibre.com,
niklas.cassel@linaro.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: am335x-evmsk: Fix PHY mode for ethernet
Date: Mon, 18 Feb 2019 16:36:28 +0200 [thread overview]
Message-ID: <20190218143629.28392-2-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20190218143629.28392-1-peter.ujfalusi@ti.com>
The PHY must add both tx and rx delay and not only on the tx clock.
The board uses AR8031_AL1A PHY where the rx delay is enabled by default,
the tx dealy is disabled.
The reason why rgmii-txid worked because the rx delay was not disabled by
the driver so essentially we ended up with rgmii-id PHY mode.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/boot/dts/am335x-evmsk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index 172c0224e7f6..b128998097ce 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -651,13 +651,13 @@
&cpsw_emac0 {
phy-handle = <ðphy0>;
- phy-mode = "rgmii-txid";
+ phy-mode = "rgmii-id";
dual_emac_res_vlan = <1>;
};
&cpsw_emac1 {
phy-handle = <ðphy1>;
- phy-mode = "rgmii-txid";
+ phy-mode = "rgmii-id";
dual_emac_res_vlan = <2>;
};
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-02-18 14:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 14:36 [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet Peter Ujfalusi
2019-02-18 14:36 ` Peter Ujfalusi [this message]
2019-02-18 14:36 ` [PATCH 2/2] ARM: dts: am335x-evm: " Peter Ujfalusi
2019-02-18 14:44 ` [PATCH 0/2] ARM: dts: am335x-evm/evmsk: " Tony Lindgren
2019-02-18 16:22 ` Peter Ujfalusi
2019-02-18 16:26 ` Tony Lindgren
2019-02-19 8:02 ` Peter Ujfalusi
2019-02-19 16:52 ` Tony Lindgren
2019-02-20 8:30 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218143629.28392-2-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox