From: Andreas Kemnade <andreas@kemnade.info>
To: Tony Lindgren <tony@atomide.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
kishon@ti.com, lee.jones@linaro.org, daniel.thompson@linaro.org,
wsa@the-dreams.de, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>
Subject: Re: [PATCH v2] phy: phy-twl4030-usb: fix denied runtime access
Date: Thu, 21 Feb 2019 17:08:40 +0100 [thread overview]
Message-ID: <20190221170840.5c970def@kemnade.info> (raw)
In-Reply-To: <20190220223132.GV15711@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]
Hi,
On Wed, 20 Feb 2019 14:31:32 -0800
Tony Lindgren <tony@atomide.com> wrote:
> * Andreas Kemnade <andreas@kemnade.info> [180922 09:48]:
> > When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS,
> > the counter will be incremented but the resume callback not called,
> > so enumeration and charging will not start properly.
> > To avoid that happen, disable irq on suspend and recheck on resume.
> >
> > Practically this happens when the device is woken up from suspend by
> > plugging in usb.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > Changes in v2:
> > * use pm suspend/resume callback instead of delayed_work
> > as suggested by Dmitry
>
> Hmm it just occurred to me that this issue too might be fixed with commit
> c6e2bd956936 ("i2c: omap: Use noirq system sleep pm ops to idle device
> for suspend"). Andreas, care to check? That is if this is still an
> issue.
>
this one made already its way into 4.20. But for the records, I will
build the latest 5.0-rc and revert it and will check if the problem
still occurs.
I do not think the patch you mentioned has something to do with this
because here solely the problem is about things happen on resume.
But on gta04 we had several irregular behavior regarding to actions
on the other i2c bus where all the sensors and touchscreen are located.
It happens rarely and most often when I am not up to debugging it.
So maybe your patch helps there.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-21 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 9:44 [PATCH v2] phy: phy-twl4030-usb: fix denied runtime access Andreas Kemnade
2019-02-20 22:31 ` Tony Lindgren
2019-02-21 16:08 ` Andreas Kemnade [this message]
2019-02-21 16:48 ` Tony Lindgren
2019-02-21 19:39 ` Andreas Kemnade
2019-02-21 21:27 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221170840.5c970def@kemnade.info \
--to=andreas@kemnade.info \
--cc=daniel.thompson@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).