From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee.jones@linaro.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org,
Alessandro Rubini <rubini@gnudd.com>,
Arnd Bergmann <arnd@arndb.de>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Cory Maccarrone <darkstar6262@gmail.com>,
Davide Ciminaghi <ciminaghi@gnudd.com>,
Dong Aisheng <dong.aisheng@linaro.org>,
Graeme Gregory <gg@slimlogic.co.uk>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
Jin Park <jinyoungp@nvidia.com>,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
Laxman Dewangan <ldewangan@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Mattias Nilsson <mattias.i.nilsson@stericsson.com>,
Michael
Subject: Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers
Date: Thu, 7 Mar 2019 08:11:40 -0800 [thread overview]
Message-ID: <20190307161140.GJ39872@atomide.com> (raw)
In-Reply-To: <20190307083518.GA8052@amd>
* Pavel Machek <pavel@ucw.cz> [190307 08:35]:
>
> > > Pavel, I hope this more extended explanation makes sense to you, and
> > > that you simply have not seen me write these same details in the past.
> >
> > Blimey. That's a really long winded way of saying:
> >
> > "Modular-ness is actually broken in these drivers; [Paul]'s patches
> > make that point clear for all to see. If people (authors/distros)
> > wish them to be modular, they need to fix them properly."
>
> Has that been checked?
>
> I mean... when I saw the patch I thought "perhaps it should be doing
> bool->tristate instead"?
Thinking distors and loadable modules, for PMICs, only regulators need
to be built-in in most cases. That's at least the case for example with
drivers/mfd/motorola-cpcap.c.
I'd say applying these patches makes sense unless we have people
step up and fix their drivers.
Regards,
Tony
prev parent reply other threads:[~2019-03-07 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 18:36 [PATCH v5 00/18] mfd: demodularization of non-modular drivers Paul Gortmaker
2019-01-13 18:36 ` [PATCH 11/18] mfd: tps65910: Make it explicitly non-modular Paul Gortmaker
2019-01-16 13:24 ` [PATCH v5 00/18] mfd: demodularization of non-modular drivers Lee Jones
2019-03-06 23:10 ` Pavel Machek
2019-03-07 4:18 ` Paul Gortmaker
2019-03-07 8:25 ` Lee Jones
2019-03-07 8:35 ` Pavel Machek
2019-03-07 16:11 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307161140.GJ39872@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ciminaghi@gnudd.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=darkstar6262@gmail.com \
--cc=dong.aisheng@linaro.org \
--cc=g.liakhovetski@gmx.de \
--cc=gg@slimlogic.co.uk \
--cc=haojian.zhuang@marvell.com \
--cc=jedu@slimlogic.co.uk \
--cc=jinyoungp@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.i.nilsson@stericsson.com \
--cc=paul.gortmaker@windriver.com \
--cc=pavel@ucw.cz \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).