From: Tony Lindgren <tony@atomide.com>
To: Christina Quast <cquast@hanoverdisplays.com>
Cc: bcousson@baylibre.com, robh+dt@kernel.org, mark.rutland@arm.com,
mpfj@newflow.co.uk, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: am335x: Replaced register offsets with defines
Date: Thu, 14 Mar 2019 08:05:24 -0700 [thread overview]
Message-ID: <20190314150524.GB19425@atomide.com> (raw)
In-Reply-To: <20190313142724.27446-3-cquast@hanoverdisplays.com>
* Christina Quast <cquast@hanoverdisplays.com> [190313 14:28]:
> The defines are taken from dt-bindings/pinctrl/am335x.h
>
> Updated AM33XX_IOPAD to take three instead of two parameters:
> AM33XX_IOPAD(register_offset, pin_direction_pullups, mux_mode)
Thanks that works great for making things work eventually
with #pinctrl-cells = <2> :)
> + AM33XX_IOPAD(AM335X_PIN_UART1_RXD, PIN_INPUT, MUX_MODE0) /* uart1_rxd */
> + AM33XX_IOPAD(AM335X_PIN_UART1_TXD, PIN_INPUT, MUX_MODE0) /* uart1_txd *
Since it sounds like you're modifying these with a script,
just leave out any nop comments while at it where the comment
is just the pad name already there in the new register
define. Some comments might need to be preserved, but my
guess is that they're mostly just the pad name.
And I suggest you split this change to a seprate patch
for each board so in case of trouble we can revert the
changes for a single board if needed.
Regards,
Tony
next prev parent reply other threads:[~2019-03-14 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 14:27 [PATCH 0/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines Christina Quast
2019-03-13 14:27 ` [PATCH 1/2] " Christina Quast
2019-03-14 14:59 ` Tony Lindgren
2019-03-13 14:27 ` [PATCH 2/2] ARM: dts: am335x: Replaced register offsets with defines Christina Quast
2019-03-14 15:05 ` Tony Lindgren [this message]
[not found] ` <4FA4A861EC9F6744BE8446EF2CDFAFE11FF8885D@mail.hanover.local>
2019-03-14 16:12 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2018-04-30 11:20 [PATCH 0/2] Add macro defines for AM335x Christina Quast
2018-04-30 11:20 ` [PATCH 2/2] ARM: dts: am335x: Replaced register offsets with defines Christina Quast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314150524.GB19425@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=cquast@hanoverdisplays.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpfj@newflow.co.uk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).