From: Tony Lindgren <tony@atomide.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: dri-devel@lists.freedesktop.org,
Sebastian Reichel <sre@kernel.org>, Jyri Sarha <jsarha@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] omapdrm: hdmi4_cec: Fix CEC clock handling for PM
Date: Tue, 26 Mar 2019 07:36:22 -0700 [thread overview]
Message-ID: <20190326143622.GA49658@atomide.com> (raw)
In-Reply-To: <8e286eaf-59cf-4c5a-adb3-edf2cd76f443@xs4all.nl>
* Hans Verkuil <hverkuil@xs4all.nl> [190326 06:36]:
> On 3/26/19 12:47 AM, Tony Lindgren wrote:
> > @@ -169,12 +169,19 @@ static int hdmi_cec_adap_enable(struct cec_adapter *adap, bool enable)
> > struct hdmi_core_data *core = cec_get_drvdata(adap);
> > int temp, err;
> >
> > - if (!enable) {
> > + if (enable) {
> > + /*
> > + * Initialize CEC clock divider: CEC needs 2MHz clock hence
> > + * set the divider to 24 to get 48/24=2MHz clock
> > + */
> > + REG_FLD_MOD(core->wp->base, HDMI_WP_CLK, 0x18, 5, 0);
>
> Please move this to after the 'if'. That's where all the other
> 'enable' code is.
Oops yeah that's better, will post v2 shortly.
Regards,
Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-03-26 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 23:47 [PATCH] omapdrm: hdmi4_cec: Fix CEC clock handling for PM Tony Lindgren
2019-03-26 2:21 ` Laurent Pinchart
2019-03-26 6:36 ` Hans Verkuil
2019-03-26 14:36 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326143622.GA49658@atomide.com \
--to=tony@atomide.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).