Re: [RFC PATCH v2 3/7] i2c: core: introduce callbacks for atomic transfers

Wolfram Sang
2019-03-27T13:47:51Z

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

Hi Simon,

please delete unrelated text. I nearly missed the typo fix later.

> > - if (in_atomic() || irqs_disabled())
> > + if (in_atomic() || irqs_disabled()) {
> > + WARN(!adap->algo->master_xfer_atomic && !adap->algo->smbus_xfer_atomic,
> > + "No atomic I2C transfer handler for '%s'\n", dev_name(&adap->dev));
>
> Is WARN_ONCE more appropriate here?

Why? It could be multiple adapters or clients causing this?

> > + * The return codes from the @master_xfer{_atomic} field should indicate the
>
> I think "field" should be "fields" in the new text.

Fixed, thanks!

Regards,

Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]