Re: [RFC PATCH v2 5/7] i2c: busses: omap: Add the master_xfer_irqless hook

Wolfram Sang
2019-03-27T13:50:45Z

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

> > > + if (!ret)
> > > + timeout = 1;
> > > + else
> > > + timeout = 0;
> >
> >
> > nit: the following might be cleaner
> >
> > ret = !!timeout;
> >
>
> Other way around, perhaps,
>
> timeout = !ret;

I saw that but didn't want to modify this patch. But yes, this is easy
enough and looks a lot better.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]