Re: [RFC PATCH v2 5/7] i2c: busses: omap: Add the master_xfer_irqless hook

Andy Shevchenko
2019-03-15T13:14:35Z

On Fri, Mar 15, 2019 at 01:47:18PM +0100, Simon Horman wrote:
> On Sat, Mar 02, 2019 at 02:47:33PM +0100, Wolfram Sang wrote:

> > + if (!polling) {
> > + timeout = wait_for_completion_timeout(&omap->cmd_complete,
> > + OMAP_I2C_TIMEOUT);
> > + } else {
> > + do {
> > + omap_i2c_wait(omap);
> > + ret = omap_i2c_xfer_data(omap);
> > + } while (ret == -EAGAIN);
> > +
> > + if (!ret)
> > + timeout = 1;
> > + else
> > + timeout = 0;
>
>
> nit: the following might be cleaner
>
> ret = !!timeout;
>

Other way around, perhaps,

timeout = !ret;

> > + }

--
With Best Regards,
Andy Shevchenko