From: YueHaibing <yuehaibing@huawei.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: YueHaibing <yuehaibing@huawei.com>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH v2 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
Date: Mon, 29 Apr 2019 14:31:57 +0000 [thread overview]
Message-ID: <20190429143157.79035-1-yuehaibing@huawei.com> (raw)
In-Reply-To: <20190429135650.72794-1-yuehaibing@huawei.com>
Change the call to PTR_ERR to access the value just tested by IS_ERR.
Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
v2: add Fixes tag
---
drivers/net/ethernet/ti/cpsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c3cba46fac9d..e37680654a13 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2381,7 +2381,7 @@ static int cpsw_probe(struct platform_device *pdev)
clk = devm_clk_get(dev, "fck");
if (IS_ERR(clk)) {
- ret = PTR_ERR(mode);
+ ret = PTR_ERR(clk);
dev_err(dev, "fck is not found %d\n", ret);
return ret;
}
next prev parent reply other threads:[~2019-04-29 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 13:56 [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() YueHaibing
2019-04-29 13:56 ` Andrew Lunn
2019-04-29 14:17 ` YueHaibing
2019-04-29 14:31 ` YueHaibing [this message]
2019-04-29 16:30 ` [PATCH v2 " Julia Lawall
2019-04-30 1:33 ` YueHaibing
2019-04-30 1:55 ` [PATCH v3 " YueHaibing
2019-05-01 18:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429143157.79035-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=andrew@lunn.ch \
--cc=grygorii.strashko@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox