From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 0/2] drm/panel-simple: Add panel parameters for ortustech-com37h3m05dtc/99dtc and sharp-lq070y3dg3b Date: Wed, 5 Jun 2019 10:29:42 +0200 Message-ID: <20190605082942.GC15169@ravnborg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: Thierry Reding , David Airlie , Daniel Vetter , tomi.valkeinen@ti.com, imirkin@alum.mit.edu, marek.belisko@gmail.com, letux-kernel@openphoenux.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-omap@vger.kernel.org Hi Nikolaus. Thanks for the new panel patches. On Wed, Jun 05, 2019 at 07:07:01AM +0200, H. Nikolaus Schaller wrote: > V2: > * fix typo in 99dtc panel compatible string (reported by imirkin@alum.mit.edu) > > V1: > > Since v5.2-rc1 OMAP is no longer using a special display driver architecture > for DPI panels, but uses the general drm/panel/panel-simple. > > So we finally can add SoC independent panel definitions for two panel models > which we already had worked on quite a while ago (before device tree was > introduced): > > https://patchwork.kernel.org/patch/2851295/ > > > > H. Nikolaus Schaller (2): > drm/panel: simple: Add Sharp LQ070Y3DG3B panel support > drm/panel: simple: Add Ortustech COM37H3M panel support All three panels are missing binding documentation. Please submit binding documentation, in separate patches, with proper "dt-bindings: xxx" subjects. See Documentation/device-tree/bindings/submitting... Patches not applied due to the missing docs. But the patches itself looked good. You have specified bus_flags etc, and added the new entries in correct alphabetical order etc. Sam