Re: [PATCH-next 01/20] gpio: gpio-omap: ensure irq is enabled before wakeup

Linus Walleij
2019-06-12T07:54:50Z

On Mon, Jun 10, 2019 at 7:11 PM Grygorii Strashko
<grygorii.strashko@ti.com> wrote:

> From: Russell King <rmk+kernel@armlinux.org.uk>
>
> Documentation states:
>
> NOTE: There must be a correlation between the wake-up enable and
> interrupt-enable registers. If a GPIO pin has a wake-up configured
> on it, it must also have the corresponding interrupt enabled (on
> one of the two interrupt lines).
>
> Ensure that this condition is always satisfied by enabling the detection
> events after enabling the interrupt, and disabling the detection before
> disabling the interrupt. This ensures interrupt/wakeup events can not
> happen until both the wakeup and interrupt enables correlate.
>
> If we do any clearing, clear between the interrupt enable/disable and
> trigger setting.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Patch applied.

Yours,
Linus Walleij