From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH V2 00/15] cleanup cppcheck signed shifting errors Date: Mon, 24 Jun 2019 17:28:18 +0200 Message-ID: <20190624152818.GX3463@hirez.programming.kicks-ass.net> References: <20190623151313.970-1-tranmanphong@gmail.com> <20190624135105.15579-1-tranmanphong@gmail.com> <20190624152743.GG3436@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190624152743.GG3436@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org To: Phong Tran Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk List-Id: linux-omap@vger.kernel.org On Mon, Jun 24, 2019 at 05:27:43PM +0200, Peter Zijlstra wrote: > On Mon, Jun 24, 2019 at 08:50:50PM +0700, Phong Tran wrote: > > There are errors with cppcheck > > > > "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" > > As I've already told you; your checker is bad. That is not in face Bah, fact, typing hard. > undefined behaviour in the kernel. > > That's not to say you shouldn't clean up the code, but don't give broken > checkout output as a reason.