Regression in next with codec unload and snd_soc_component_get/put

Regression in next with codec unload and snd_soc_component_get/put

[Tony Lindgren]

Hi,

Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
snd_soc_component_get/put()") causes a regression where trying
to rmmod a codec driver fails with module is in use error after
rmmod of snd-soc-audio-graph-card for example.

Any ideas what goes wrong there?

BTW, looks like the lore.kernel.org link in that commit also is
unreachable?

Regards,

Tony

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

[Takashi Iwai]

On Fri, 09 Aug 2019 09:00:03 +0200,
Tony Lindgren wrote:
> 
> Hi,
> 
> Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> snd_soc_component_get/put()") causes a regression where trying
> to rmmod a codec driver fails with module is in use error after
> rmmod of snd-soc-audio-graph-card for example.
> 
> Any ideas what goes wrong there?

There is an obvious typo: soc_cleanup_component() should call
snd_soc_component_module_put_when_remove() instead of *_close().

And the module_get_upon_open boolean switch is a bit hard to
understand.  Maybe using enum would be simpler there.

> BTW, looks like the lore.kernel.org link in that commit also is
> unreachable?

It's because alsa-devel ML isn't tracked on lore.kernel.org,
unfortunately.

Jaroslav, I asked this already.  Shall we ask lore to track alsa-devel
ML?
  https://korg.wiki.kernel.org/userdoc/lore


thanks,

Takashi

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

[Tony Lindgren]

* Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> On Fri, 09 Aug 2019 09:00:03 +0200,
> Tony Lindgren wrote:
> > 
> > Hi,
> > 
> > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > snd_soc_component_get/put()") causes a regression where trying
> > to rmmod a codec driver fails with module is in use error after
> > rmmod of snd-soc-audio-graph-card for example.
> > 
> > Any ideas what goes wrong there?
> 
> There is an obvious typo: soc_cleanup_component() should call
> snd_soc_component_module_put_when_remove() instead of *_close().

Making that change locally seems to fix it thanks.

> And the module_get_upon_open boolean switch is a bit hard to
> understand.  Maybe using enum would be simpler there.
> 
> > BTW, looks like the lore.kernel.org link in that commit also is
> > unreachable?
> 
> It's because alsa-devel ML isn't tracked on lore.kernel.org,
> unfortunately.
> 
> Jaroslav, I asked this already.  Shall we ask lore to track alsa-devel
> ML?
>   https://korg.wiki.kernel.org/userdoc/lore

Regards,

Tony

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

[Takashi Iwai]

On Fri, 09 Aug 2019 09:46:43 +0200,
Tony Lindgren wrote:
> 
> * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > On Fri, 09 Aug 2019 09:00:03 +0200,
> > Tony Lindgren wrote:
> > > 
> > > Hi,
> > > 
> > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > snd_soc_component_get/put()") causes a regression where trying
> > > to rmmod a codec driver fails with module is in use error after
> > > rmmod of snd-soc-audio-graph-card for example.
> > > 
> > > Any ideas what goes wrong there?
> > 
> > There is an obvious typo: soc_cleanup_component() should call
> > snd_soc_component_module_put_when_remove() instead of *_close().
> 
> Making that change locally seems to fix it thanks.

... and it was already fixed in the later commit 0e36f36b04e7
"ASoC: soc-core: fix module_put() warning in soc_cleanup_component".


Takashi

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

[Tony Lindgren]

* Takashi Iwai <tiwai@suse.de> [190809 08:24]:
> On Fri, 09 Aug 2019 09:46:43 +0200,
> Tony Lindgren wrote:
> > 
> > * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > > On Fri, 09 Aug 2019 09:00:03 +0200,
> > > Tony Lindgren wrote:
> > > > 
> > > > Hi,
> > > > 
> > > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > > snd_soc_component_get/put()") causes a regression where trying
> > > > to rmmod a codec driver fails with module is in use error after
> > > > rmmod of snd-soc-audio-graph-card for example.
> > > > 
> > > > Any ideas what goes wrong there?
> > > 
> > > There is an obvious typo: soc_cleanup_component() should call
> > > snd_soc_component_module_put_when_remove() instead of *_close().
> > 
> > Making that change locally seems to fix it thanks.
> 
> ... and it was already fixed in the later commit 0e36f36b04e7
> "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".

Mark, looks like this commit is still not in Linux next, forgot
to push out something?

Regards,

Tony

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

On Tue, Aug 13, 2019 at 03:24:51AM -0700, Tony Lindgren wrote:
> * Takashi Iwai <tiwai@suse.de> [190809 08:24]:

> > ... and it was already fixed in the later commit 0e36f36b04e7
> > "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".

> Mark, looks like this commit is still not in Linux next, forgot
> to push out something?

There's a build failure the Intel guys haven't fixed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

[Pierre-Louis Bossart]

On 8/13/19 6:29 AM, Mark Brown wrote:
> On Tue, Aug 13, 2019 at 03:24:51AM -0700, Tony Lindgren wrote:
>> * Takashi Iwai <tiwai@suse.de> [190809 08:24]:
> 
>>> ... and it was already fixed in the later commit 0e36f36b04e7
>>> "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
> 
>> Mark, looks like this commit is still not in Linux next, forgot
>> to push out something?
> 
> There's a build failure the Intel guys haven't fixed.

see ('ASoC: SOF: fix HDA direct MMIO access') posted on alsa-devel 
yesterday

https://mailman.alsa-project.org/pipermail/alsa-devel/2019-August/153914.html