From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init() Date: Wed, 28 Aug 2019 11:30:07 -0700 Message-ID: <20190828183007.GD52127@atomide.com> References: <69025c8c-8d84-6686-138b-cde59467b802@web.de> <20190826162050.GX52127@atomide.com> <20190827181457.GA16333@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190827181457.GA16333@lenoch> Sender: linux-kernel-owner@vger.kernel.org To: Ladislav Michl Cc: Markus Elfring , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kishore Kadiyala , Russell King , LKML , kernel-janitors@vger.kernel.org, Balaji T K , Benoit Cousson , Paul Walmsley , Nikolaus Schaller List-Id: linux-omap@vger.kernel.org * Ladislav Michl [190827 18:15]: > On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > > * Markus Elfring [190826 06:31]: > > > From: Markus Elfring > > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > > > A null pointer would be passed to a call of the function "kfree" directly > > > after a call of the function "kzalloc" failed at one place. > > > Remove this superfluous function call. > > > > > > This issue was detected by using the Coccinelle software. > > > > Applying into omap-for-v5.4/soc thanks. > > Is it really wise touching almost dead code? Last user is pandora board, so > +Cc: Nikolaus Schaller Yeah would be good to finally get rid of that old code. Anyways, I'll keep the $subject patch to cut down on coccinelle produced issue. Regards, Tony