From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, Jyri Sarha <jsarha@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var
Date: Tue, 8 Oct 2019 07:21:53 -0700 [thread overview]
Message-ID: <20191008142153.GD5610@atomide.com> (raw)
In-Reply-To: <ffb498fb-5041-d3e9-2702-879f3d389adf@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [191008 14:17]:
> On 08/10/2019 17:13, Tony Lindgren wrote:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [190930 10:38]:
> > > If use_mclk is false, mclk_mode is written to a register without
> > > initialization. This doesn't cause any ill effects as the written value
> > > is not used when use_mclk is false.
> > >
> > > To fix this, write use_mclk only when use_mclk is true.
> >
> > Hey nice catch. Based on a quick test looks like this fixes an
> > issue where power consumption stays higher after using HDMI.
> >
> > Would be nice to have merged in the v5.4-rc series:
> >
> > Tested-by: Tony Lindgren <tony@atomide.com>
>
> Really? Ok, well, then it was a good random find =).
Yeah so it seems :) Earlier I thought there's still some
clkctrl setting wrong after using HDMI, but did not see
anything diffing the clkctrl registers before and after
and gave up.
> I did already push this to drm-misc-next, as I thought it does not have any
> real effect. I'll check if it's ok to push to drm-misc-fixes too, with Cc
> stable.
OK great thanks.
Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-08 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190930103840.18970-1-tomi.valkeinen@ti.com>
[not found] ` <20190930103840.18970-8-tomi.valkeinen@ti.com>
2019-10-08 14:13 ` [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var Tony Lindgren
2019-10-08 14:16 ` Tomi Valkeinen
2019-10-08 14:21 ` Tony Lindgren [this message]
2019-10-10 6:47 ` Tomi Valkeinen
2019-10-10 13:24 ` Tony Lindgren
2019-10-11 10:25 ` Tomi Valkeinen
2019-10-11 16:10 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008142153.GD5610@atomide.com \
--to=tony@atomide.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).