From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Merlijn Wajer <merlijn@wizzup.org>,
linux-omap@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/8] ARM: OMAP2+: Allow core oswr for omap4
Date: Sun, 13 Oct 2019 17:08:07 +0200 [thread overview]
Message-ID: <20191013150806.GE13278@amd> (raw)
In-Reply-To: <20191010001224.41826-8-tony@atomide.com>
[-- Attachment #1.1: Type: text/plain, Size: 1737 bytes --]
On Wed 2019-10-09 17:12:23, Tony Lindgren wrote:
> Commit f74297dd9354 ("ARM: OMAP2+: Make sure LOGICRETSTATE bits are not
> cleared") disabled oswr (open switch retention) for per and core domains
> as various GPIO related issues were noticed if the bootloader had
> configured the bits for LOGICRETSTATE for per and core domains.
>
> With the recent gpio-omap fixes, mostly related to commit e6818d29ea15
> ("gpio: gpio-omap: configure edge detection for level IRQs for idle
> wakeup"), things now behave for enabling core oswr for omap4.
>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
2,7,8 basically modify same lines of code? Should that be done in one
patch?
Best regards,
Pavel
>
> - /*
> - * Bootloader or kexec boot may have LOGICRETSTATE cleared
> - * for some domains. This is the case when kexec booting from
> - * Android kernels that support off mode for example.
> - * Make sure it's set at least for core and per, otherwise
> - * we currently will see lost GPIO interrupts for wlcore and
> - * smsc911x at least if per hits retention during idle.
> - */
> - if (!strncmp(pwrdm->name, "core", 4)
> - pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_RET);
> -
> - if (!strncmp(pwrdm->name, "l4per", 5)
> + if (!strncmp(pwrdm->name, "core", 4) ||
> + !strncmp(pwrdm->name, "l4per", 5))
> pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_OFF);
>
> pwrst = kmalloc(sizeof(struct power_state), GFP_ATOMIC);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-13 15:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 0:12 [PATCH 0/8] Improve PM for omap4 devices Tony Lindgren
2019-10-10 0:12 ` [PATCH 1/8] ARM: OMAP2+: Remove unused wakeup_cpu Tony Lindgren
2019-10-13 11:38 ` Pavel Machek
2019-10-10 0:12 ` [PATCH 2/8] ARM: OMAP2+: Drop bogus wkup domain oswr setting Tony Lindgren
2019-10-13 15:07 ` Pavel Machek
2019-10-16 14:40 ` Tony Lindgren
2019-10-10 0:12 ` [PATCH 3/8] ARM: OMAP2+: Remove bogus warnings for machines without twl PMIC Tony Lindgren
2019-10-10 0:12 ` [PATCH 4/8] ARM: OMAP2+: Update 4430 voltage controller operating points Tony Lindgren
2019-10-10 0:12 ` [PATCH 5/8] ARM: OMAP2+: Configure voltage controller for cpcap Tony Lindgren
2019-10-13 14:46 ` Pavel Machek
2019-10-10 0:12 ` [PATCH 6/8] ARM: OMAP2+: Allow per oswr for omap4 Tony Lindgren
2019-10-10 0:12 ` [PATCH 7/8] ARM: OMAP2+: Allow core " Tony Lindgren
2019-10-13 15:08 ` Pavel Machek [this message]
2019-10-16 14:46 ` Tony Lindgren
2019-10-10 0:12 ` [PATCH 8/8] ARM: OMAP2+: Initialize voltage controller " Tony Lindgren
2019-10-13 15:08 ` Pavel Machek
2019-10-16 14:53 ` Tony Lindgren
2019-10-17 1:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013150806.GE13278@amd \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).