From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 07/11] omap: remove old hsmmc.[ch] and in Makefile Date: Mon, 21 Oct 2019 10:11:04 -0700 Message-ID: <20191021171104.GY5610@atomide.com> References: <9bd4c0bb0df26523d7f5265cdb06d86d63dafba8.1571510481.git.hns@goldelico.com> <20191021143008.GS5610@atomide.com> <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com> Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: Mark Rutland , Ulf Hansson , devicetree@vger.kernel.org, Yangtao Li , linux-wireless@vger.kernel.org, Kefeng Wang , Bjorn Helgaas , letux-kernel@openphoenux.org, "Rafael J. Wysocki" , Russell King , Mike Rapoport , Kalle Valo , Petr Mladek , =?utf-8?Q?Beno=C3=AEt?= Cousson , kernel@pyra-handheld.com, Alexios Zavras , Rob Herring , John Stultz , David Sterba , Thomas Gleixner linu List-Id: linux-omap@vger.kernel.org * H. Nikolaus Schaller [191021 17:08]: > > > Am 21.10.2019 um 16:30 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [191019 18:43]: > >> --- a/arch/arm/mach-omap2/Makefile > >> +++ b/arch/arm/mach-omap2/Makefile > >> @@ -216,7 +216,6 @@ obj-$(CONFIG_MACH_NOKIA_N8X0) += board-n8x0.o > >> > >> # Platform specific device init code > >> > >> -omap-hsmmc-$(CONFIG_MMC_OMAP_HS) := hsmmc.o > >> obj-y += $(omap-hsmmc-m) $(omap-hsmmc-y) > > > > The related obj-y line can go now too, right? > > Yes, I think so. It is a construction that I have never seen before :) > Therefore I did not recognize that it is related. > > > And looks like common.h also has struct omap2_hsmmc_info > > so maybe check by grepping for hsmmc_info to see it's gone. > > Yes, it is just a forward-declaration of the struct name with > no user anywhere. > > Scheduled for v3. > > BTW: should this series go through your tree since it is an > omap machine? Or MMC tree as that's where the code change really are. Regards, Tony