From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [Patch 5/9] arm: dts: dra72-evm-common: Add entries for the CSI2 cameras Date: Tue, 22 Oct 2019 08:44:46 -0700 Message-ID: <20191022154446.GN5610@atomide.com> References: <20191018154849.3127-1-bparrot@ti.com> <20191018154849.3127-6-bparrot@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191018154849.3127-6-bparrot@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Benoit Parrot Cc: Tero Kristo , Rob Herring , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Benoit Parrot [191018 15:46]: > Add device nodes for CSI2 camera board OV5640. > Add the CAL port nodes with the necessary linkage to the ov5640 nodes. > > Signed-off-by: Benoit Parrot > --- > arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi > index 8641a3d7d8ad..e4c01a67f6de 100644 > --- a/arch/arm/boot/dts/dra72-evm-common.dtsi > +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi > @@ -187,6 +187,12 @@ > gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + clk_ov5640_fixed: clk_ov5640_fixed { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > + }; > }; The clock node name should be generic and not use undescores. If there is a hidden dependency to the clock node name here, it should be mentioned in the patch for the non-standard use. Regards, Tony