From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Tero Kristo" <t-kristo@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Adam Ford" <adam.ford@logicpd.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Russell King" <linux@armlinux.org.uk>,
"Paul Walmsley" <paul@pwsan.com>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC] ARM: omap3: Enable HWMODS for HW Random Number Generator
Date: Tue, 22 Oct 2019 09:06:43 -0700 [thread overview]
Message-ID: <20191022160643.GR5610@atomide.com> (raw)
In-Reply-To: <CAHCN7xJjMNOLT5oPn8CArApM5b2ksPon8eALq=gUi0ZqoLjGHQ@mail.gmail.com>
* Adam Ford <aford173@gmail.com> [191022 12:13]:
> On Mon, Sep 9, 2019 at 11:35 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Pali Rohár <pali.rohar@gmail.com> [190909 13:41]:
> > > On Monday 09 September 2019 08:37:09 Adam Ford wrote:
> > > > I applied this on 5.3 and it is working. I assume the same is true in for-next.
> >
> > Hmm I noticed I stopped getting RNG data after several rmmod modprobe
> > cycles, or several hd /dev/random reads. Anybody else seeing that?
> >
> > > > Do you want to submit a formal patch? I can mark it as 'tested-by'
> > > > This really helps speed up the startup sequence on boards with sshd
> > > > because it delays for nearly 80 seconds waiting for entropy without
> > > > the hwrng.
> > >
> > > Hi! When applying a patch, could you please disable this rng for n900?
> > >
> > > In omap3-n900.dts for rng should be status = "disabled" (as Tony already
> > > wrote), similarly like for aes.
> >
> > Yeah I'll post a proper patch after -rc1.
>
> Tony,
>
> I am just following up on this. Without the HWRNG there are some
> tools and daemons like sshd which wait a long time at startup. The
> patch you sent really helps speed up the startup time in these cases.
> At least in my case, it shaves 80 seconds off by eliminating the
> delays.
>
> Do you think you'll have time to post a more formal patch? If not, I
> can do it. I just don't know which mailing list is the more
> appropriate. I was able to verity your patch on a DM3730 and OMAP3530
Yeah sorry for the delays, I'll post it when I get a chance to
work on that again. I need to first deal with the other pending
patches for v5.5, and we've had quite a few fixes for v5.4.
Regards,
Tony
next prev parent reply other threads:[~2019-10-22 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 15:00 [RFC] ARM: omap3: Enable HWMODS for HW Random Number Generator Adam Ford
2019-09-05 23:04 ` Tony Lindgren
2019-09-09 12:13 ` Adam Ford
2019-09-09 13:37 ` Adam Ford
2019-09-09 13:40 ` Pali Rohár
2019-09-09 16:35 ` Tony Lindgren
2019-09-09 19:19 ` Adam Ford
2019-09-10 15:48 ` Adam Ford
2019-09-10 16:21 ` Adam Ford
2019-09-10 16:39 ` Pali Rohár
2019-10-22 12:13 ` Adam Ford
2019-10-22 16:06 ` Tony Lindgren [this message]
2019-09-10 13:56 ` Adam Ford
2019-09-10 14:37 ` Sebastian Reichel
2019-09-10 14:44 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022160643.GR5610@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=adam.ford@logicpd.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=paul@pwsan.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).