From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [Patch 0/3] ARM: dts: dra7: add vpe nodes Date: Tue, 22 Oct 2019 09:46:36 -0700 Message-ID: <20191022164636.GD5610@atomide.com> References: <20191009175628.20570-1-bparrot@ti.com> <20191022162720.yile7i4qwxgbuuou@ti.com> <20191022163048.GY5610@atomide.com> <20191022163319.ceb5wkwabw3w3kou@ti.com> <20191022163754.GC5610@atomide.com> <20191022164429.4hcyrnmtvklfd4oq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191022164429.4hcyrnmtvklfd4oq@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Benoit Parrot Cc: Tero Kristo , Rob Herring , linux-omap@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Benoit Parrot [191022 16:45]: > Tony Lindgren wrote on Tue [2019-Oct-22 09:37:54 -0700]: > > * Benoit Parrot [191022 16:34]: > > > Tony Lindgren wrote on Tue [2019-Oct-22 09:30:48 -0700]: > > > > * Benoit Parrot [191022 16:28]: > > > > > Tony, > > > > > > > > > > Ping, > > > > > > > > > > I already had comments from Rob but i would like your feedback before > > > > > sending a v2. > > > > > > > > Looks good to me in general other than what Rob commented > > > > on. Did not spot any node naming issues here :) > > > > > > Would I need to split off the clk*.c/.h as well here though? > > > > Yeah please do patches with just drivers/clk/ti and > > include/dt-bindings/clock changes in them. then Tero > > can queue them into an immutable branch that I can merge > > in too and use as a base for the dts changes. > > Although the .h is in include/dt-binding. Does it still belong in the same > patch as drivers/clk/ti/clk-7xx.c then? > > Just making sure.... Yes if it's needed to compile the drivers/clk/ti patch. Otherwise it can stay with the dts changes. Regards, Tony