From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-omap@vger.kernel.org, hns@goldelico.com,
adam.ford@logicpd.com, Eduardo Valentin <edubezval@gmail.com>,
Keerthy <j-keerthy@ti.com>, Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: ti-soc-thermal: Enable addition power management
Date: Fri, 8 Nov 2019 13:17:17 -0800 [thread overview]
Message-ID: <20191108211717.GR5610@atomide.com> (raw)
In-Reply-To: <20191108205954.20136-1-aford173@gmail.com>
* Adam Ford <aford173@gmail.com> [191108 21:00]:
> +static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
> + unsigned long cmd, void *v);
>
> /*** Helper functions to access registers and their bitfields ***/
>
> @@ -1025,6 +1033,9 @@ int ti_bandgap_probe(struct platform_device *pdev)
> }
> }
>
> + bgp->nb.notifier_call = bandgap_omap_cpu_notifier;
> + cpu_pm_register_notifier(&bgp->nb);
> +
Hmm looks like you're missing the related call to
cpu_pm_unregister_notifier(), right?
Other than that, it also works on droid4, so please
feel free to add:
Reviewed-by: Tony Lindgren <tony@atomide.com>
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2019-11-08 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 20:59 [PATCH] thermal: ti-soc-thermal: Enable addition power management Adam Ford
2019-11-08 21:17 ` Tony Lindgren [this message]
2019-11-08 21:23 ` Adam Ford
-- strict thread matches above, loose matches on Subject: below --
2019-11-08 20:05 Adam Ford
2019-11-08 20:45 ` Tony Lindgren
2019-11-08 20:50 ` Tony Lindgren
2019-11-08 20:57 ` Adam Ford
2019-11-08 21:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108211717.GR5610@atomide.com \
--to=tony@atomide.com \
--cc=adam.ford@logicpd.com \
--cc=aford173@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=hns@goldelico.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).