From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] thermal: ti-soc-thermal: Enable addition power management Date: Fri, 8 Nov 2019 13:17:17 -0800 Message-ID: <20191108211717.GR5610@atomide.com> References: <20191108205954.20136-1-aford173@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191108205954.20136-1-aford173@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Adam Ford Cc: linux-omap@vger.kernel.org, hns@goldelico.com, adam.ford@logicpd.com, Eduardo Valentin , Keerthy , Zhang Rui , Daniel Lezcano , Amit Kucheria , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Adam Ford [191108 21:00]: > +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, > + unsigned long cmd, void *v); > > /*** Helper functions to access registers and their bitfields ***/ > > @@ -1025,6 +1033,9 @@ int ti_bandgap_probe(struct platform_device *pdev) > } > } > > + bgp->nb.notifier_call = bandgap_omap_cpu_notifier; > + cpu_pm_register_notifier(&bgp->nb); > + Hmm looks like you're missing the related call to cpu_pm_unregister_notifier(), right? Other than that, it also works on droid4, so please feel free to add: Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren