* [PATCH] mfd: ti_am335x_tscadc: Fix static checker warning
@ 2019-11-09 5:06 Vignesh Raghavendra
2019-11-11 11:26 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Vignesh Raghavendra @ 2019-11-09 5:06 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, linux-omap, Vignesh Raghavendra, Dan Murphy
It is possible that platform_get_resource() might return NULL and
therefore code needs to check for this condition before
de-referencing the pointer.
Therefore move the de-referencing of 'res' pointer after
devm_ioremap_resource() which would have checked the validity of the
pointer
Reported-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
drivers/mfd/ti_am335x_tscadc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
index fd111296b959..926c289cb040 100644
--- a/drivers/mfd/ti_am335x_tscadc.c
+++ b/drivers/mfd/ti_am335x_tscadc.c
@@ -182,11 +182,11 @@ static int ti_tscadc_probe(struct platform_device *pdev)
tscadc->irq = err;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- tscadc->tscadc_phys_base = res->start;
tscadc->tscadc_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(tscadc->tscadc_base))
return PTR_ERR(tscadc->tscadc_base);
+ tscadc->tscadc_phys_base = res->start;
tscadc->regmap = devm_regmap_init_mmio(&pdev->dev,
tscadc->tscadc_base, &tscadc_regmap_config);
if (IS_ERR(tscadc->regmap)) {
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: ti_am335x_tscadc: Fix static checker warning
2019-11-09 5:06 [PATCH] mfd: ti_am335x_tscadc: Fix static checker warning Vignesh Raghavendra
@ 2019-11-11 11:26 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2019-11-11 11:26 UTC (permalink / raw)
To: Vignesh Raghavendra; +Cc: linux-kernel, linux-omap, Dan Murphy
On Sat, 09 Nov 2019, Vignesh Raghavendra wrote:
> It is possible that platform_get_resource() might return NULL and
> therefore code needs to check for this condition before
> de-referencing the pointer.
> Therefore move the de-referencing of 'res' pointer after
> devm_ioremap_resource() which would have checked the validity of the
> pointer
>
> Reported-by: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/mfd/ti_am335x_tscadc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-11 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-09 5:06 [PATCH] mfd: ti_am335x_tscadc: Fix static checker warning Vignesh Raghavendra
2019-11-11 11:26 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).