From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node Date: Mon, 25 Nov 2019 07:46:21 -0800 Message-ID: <20191125154621.GY35479@atomide.com> References: <1574600246.3.0@crapouillou.net> <20191124174837.GX35479@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: Paul Cercueil , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Ralf Baechle , Paul Burton , James Hogan , dri-devel , devicetree , Linux Kernel Mailing List , Linux-OMAP , OpenPVRSGX Linux Driver Group , Discussions about the Letux Kernel , kernel@pyra-handheld.com, linux-mips@vger.kernel.org, Paul Boddie List-Id: linux-omap@vger.kernel.org * H. Nikolaus Schaller [191124 18:00]: > Hi Paul, Tony, > > > Am 24.11.2019 um 18:48 schrieb Tony Lindgren : > > > > * Paul Cercueil [191124 12:58]: > >> Le dim., nov. 24, 2019 at 12:40, H. Nikolaus Schaller a > >> écrit : > >>> and add interrupt and clocks. > > ... > >>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > >>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > >>> @@ -46,6 +46,17 @@ > >>> #clock-cells = <1>; > >>> }; > >>> > >>> + gpu: gpu@13040000 { > >> > >> We try to keep the nodes ordered by address, could you move this node where > >> it belongs? > > ... > > Yes, I have noted. > > > > >>> + compatible = "ingenic,jz4780-sgx540-120", "img,sgx540-120", > >>> "img,sgx540", "img,sgx5"; > >>> + reg = <0x13040000 0x4000>; > >>> + > >>> + clocks = <&cgu JZ4780_CLK_GPU>; > >>> + clock-names = "gpu"; > > > > Just checking.. Is there something else to configure here > > potentially in addition to the clocks? > > It doesn't look so. Unfortuantely there isn't much information > except a v3.18 kernel supported by the vendor and that one also > just has a gpu node with clock control. > > > That is, do we need to do some interconnect specific > > configuration etc in addition to the clocks to have > > runtime PM work for enabling and disabling sgx on > > jz4780? > > I think we have to leave that open for further study. OK for now, let's assume we just need to call clk_enable/disable from the PM runtime functions if a clock exists. Regards, Tony