linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
       [not found] <20191210195202.622734-1-arnd@arndb.de>
@ 2019-12-17 10:45 ` Pavel Machek
  2019-12-17 16:46   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2019-12-17 10:45 UTC (permalink / raw)
  To: Arnd Bergmann, linux-omap, tony, sre, nekit1000, mpartap, merlijn,
	martin_rysavy
  Cc: Sekhar Nori, stable, Bartosz Golaszewski, Philipp Zabel,
	David Lechner, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi!

> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
> 
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to
> `reset_controller_add_lookup'

Does omap need similar handing in 5.5-rc1?

  LD      .tmp_vmlinux1
  drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
  omap_prm.c:(.text+0x4d0): undefined reference to
  `devm_reset_controller_register'
  /data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
  make[1]: *** [vmlinux] Error 1

Enabling reset controller seems to help::

Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
  TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)

Best regards,
									Pavel
									

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
  2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER Pavel Machek
@ 2019-12-17 16:46   ` Tony Lindgren
  2019-12-21 16:20     ` Pavel Machek
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2019-12-17 16:46 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Arnd Bergmann, kernel list, linux-arm-kernel, linux-omap, sre,
	nekit1000, mpartap, merlijn, martin_rysavy, Sekhar Nori, stable,
	Bartosz Golaszewski, Philipp Zabel, David Lechner

* Pavel Machek <pavel@ucw.cz> [191217 10:46]:
> Hi!
> 
> > Selecting RESET_CONTROLLER is actually required, otherwise we
> > can get a link failure in the clock driver:
> > 
> > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > psc-da850.c:(.text+0x24): undefined reference to
> > `reset_controller_add_lookup'
> 
> Does omap need similar handing in 5.5-rc1?
> 
>   LD      .tmp_vmlinux1
>   drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
>   omap_prm.c:(.text+0x4d0): undefined reference to
>   `devm_reset_controller_register'
>   /data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
>   make[1]: *** [vmlinux] Error 1
> 
> Enabling reset controller seems to help::
> 
> Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
>   TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)

Yes see the patch Arnd recently posted to do that.

Regards,

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
  2019-12-17 16:46   ` Tony Lindgren
@ 2019-12-21 16:20     ` Pavel Machek
  0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2019-12-21 16:20 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Arnd Bergmann, kernel list, linux-arm-kernel, linux-omap, sre,
	nekit1000, mpartap, merlijn, martin_rysavy, Sekhar Nori, stable,
	Bartosz Golaszewski, Philipp Zabel, David Lechner

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

Hi!

> > > Selecting RESET_CONTROLLER is actually required, otherwise we
> > > can get a link failure in the clock driver:
> > > 
> > > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > > psc-da850.c:(.text+0x24): undefined reference to
> > > `reset_controller_add_lookup'
> > 
> > Does omap need similar handing in 5.5-rc1?
> > 
> >   LD      .tmp_vmlinux1
> >   drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
> >   omap_prm.c:(.text+0x4d0): undefined reference to
> >   `devm_reset_controller_register'
> >   /data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
> >   make[1]: *** [vmlinux] Error 1
> > 
> > Enabling reset controller seems to help::
> > 
> > Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
> >   TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)
> 
> Yes see the patch Arnd recently posted to do that.

Thanks for the hint and sorry for the noise.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-21 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20191210195202.622734-1-arnd@arndb.de>
2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER Pavel Machek
2019-12-17 16:46   ` Tony Lindgren
2019-12-21 16:20     ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).