From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 2/2] ARM: configs: Cleanup old Kconfig options Date: Sun, 9 Feb 2020 03:44:22 -0800 Message-ID: <20200209114422.as5xpytakhaa3vur@localhost> References: <20200130195525.4525-1-krzk@kernel.org> <20200130195525.4525-2-krzk@kernel.org> <9f8a0a8e09893e7087d2212fb0eeb94a908b7be1.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-lj1-f195.google.com ([209.85.208.195]:37631 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726378AbgBILv6 (ORCPT ); Sun, 9 Feb 2020 06:51:58 -0500 Received: by mail-lj1-f195.google.com with SMTP id v17so3973268ljg.4 for ; Sun, 09 Feb 2020 03:51:57 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Krzysztof Kozlowski Cc: Joe Perches , Russell King , Alexander Shiyan , Uwe Kleine-K??nig , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Tony Lindgren , Maxime Coquelin , Alexandre Torgue , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Avi Fishman , Tomer Maimon , Tali On Mon, Feb 03, 2020 at 12:52:45PM +0100, Krzysztof Kozlowski wrote: > On Thu, 30 Jan 2020 at 23:06, Joe Perches wrote: > > > > On Thu, 2020-01-30 at 20:55 +0100, Krzysztof Kozlowski wrote: > > > CONFIG_MMC_BLOCK_BOUNCE is gone since commit c3dccb74be28 ("mmc: core: > > > Delete bounce buffer Kconfig option"). > > > > > > CONFIG_LBDAF is gone since commit 72deb455b5ec ("block: remove > > > CONFIG_LBDAF"). > > > > > > CONFIG_IOSCHED_DEADLINE and CONFIG_IOSCHED_CFQ are gone since > > > commit f382fb0bcef4 ("block: remove legacy IO schedulers"). > > > > > > The IOSCHED_DEADLINE was replaced by MQ_IOSCHED_DEADLINE and it will be > > > now enabled by default (along with MQ_IOSCHED_KYBER). > > > > > > The IOSCHED_BFQ seems to replace IOSCHED_CFQ so select it in configs > > > previously choosing the latter. > > > > > > CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove > > > CONFIG_CROSS_COMPILE support"). > > > > Hi Krzysztof. > > > > There seems there are a lot more of these unused CONFIG_ > > symbols in various defconfigs. (just for arm and treewide below) > > > > ARM defconfigs: > > Hi Joe, > > Nice finding! The trickier point is to nicely remove them because: > 1. The easiest is 'savedefconfig' but then some valuable options might > disappear (like recently happened with DEBUG_FS), Note that while they disappear from the defconfig, they were already not part of the build. So kernels have been built without them for a while. It's a good way to surface the problem, but it's pretty clear that trees fall in the forest here all the time and nobody is noticing. > 2. They could be removed in automated way with a script. However in > such case what about replacements? If some symbol was replaced with > other (or just renamed), maybe we should enable the other one to > restore the desired functionality? > 3. Or maybe let's don't care about keeping defconfigs stable and just > clean them up automatically. Churning defconfigs is just noise, and a source of annoying needless conflicts when people do it at the same time. If an option is no longer in-tree, it doesn't do any harm. But it makes sense to clean up every now and then like the original patch here. -Olof