From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: LED backlight on Droid 4 and others Date: Tue, 11 Feb 2020 09:29:00 -0800 Message-ID: <20200211172900.GH64767@atomide.com> References: <20200105183202.GA17784@duo.ucw.cz> <20200106084549.GA14821@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:54770 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727785AbgBKR3F (ORCPT ); Tue, 11 Feb 2020 12:29:05 -0500 Content-Disposition: inline In-Reply-To: <20200106084549.GA14821@dell> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Lee Jones Cc: Pavel Machek , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz, agx@sigxcpu.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, jjhiblot@ti.com * Lee Jones [200106 08:46]: > On Sun, 05 Jan 2020, Pavel Machek wrote: > > > Hi! > > > > It would be good to get LED backlight to work in clean way for 5.6 > > kernel. ... > > [If you have an idea what else is needed, it would be welcome; it > > works for me in development tree but not in tree I'd like to > > upstream.] > > > > Lee, would you be willing to take "backlight: add led-backlight > > driver"? Would it help if I got "leds: Add managed API to get a LED > > from a device driver" and "leds: Add of_led_get() and led_put()" into > > for_next tree of the LED subsystem? > > It looks like you have an open question from Tony on v10. > > Is that patch orthogonal, or are there depend{ants,encies}? Uhh looks like we messed up a bit with integration. Now droid4 LCD backlight can no longer be enabled at all manually in v5.6-rc1 without the "add led-backlight driver" patch.. Should we just merge it to fix it rather than start scrambling with other temporary hacks? I don't care if we use "default-brightness", or if we use "default-brightness-level". The binding merged says now "default-brightness", so let's go with that one. That's what other LED drivers are using too. Regards, Tony