From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E9AC34022 for ; Mon, 17 Feb 2020 18:29:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C79412465A for ; Mon, 17 Feb 2020 18:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728958AbgBQS3M (ORCPT ); Mon, 17 Feb 2020 13:29:12 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:56104 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727749AbgBQS3L (ORCPT ); Mon, 17 Feb 2020 13:29:11 -0500 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23990923AbgBQS3JEK45R (ORCPT + 1 other); Mon, 17 Feb 2020 19:29:09 +0100 Date: Mon, 17 Feb 2020 19:29:06 +0100 From: Ladislav Michl To: "H. Nikolaus Schaller" Cc: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-omap@vger.kernel.org Subject: Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER Message-ID: <20200217182906.GA140676@lenoch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Feb 17, 2020 at 02:58:14PM +0100, H. Nikolaus Schaller wrote: > > > Am 17.02.2020 um 14:38 schrieb H. Nikolaus Schaller : > > > > If the gpios are probed after this driver (e.g. if they > > come from an i2c expander) there is no need to print an > > error message. > > > > Signed-off-by: H. Nikolaus Schaller > > --- > > drivers/extcon/extcon-palmas.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c > > index edc5016f46f1..cea58d0cb457 100644 > > --- a/drivers/extcon/extcon-palmas.c > > +++ b/drivers/extcon/extcon-palmas.c > > @@ -205,14 +205,18 @@ static int palmas_usb_probe(struct platform_device *pdev) > > > > palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", > > GPIOD_IN); > > - if (IS_ERR(palmas_usb->id_gpiod)) { > > + if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER) { > > + return -EPROBE_DEFER; > > + } else if (IS_ERR(palmas_usb->id_gpiod)) { > > Hm. > > While looking again at that: why do we need the "{" and "} else "? > > It should be sufficient to have > > > palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", > > GPIOD_IN); > > + if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > if (IS_ERR(palmas_usb->id_gpiod)) { > > What do you think is better coding style here? How about something like this? (just an idea with some work left for you ;-)) --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -206,8 +206,10 @@ static int palmas_usb_probe(struct platform_device *pdev) palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_IN); if (IS_ERR(palmas_usb->id_gpiod)) { - dev_err(&pdev->dev, "failed to get id gpio\n"); - return PTR_ERR(palmas_usb->id_gpiod); + status = PTR_ERR(palmas_usb->id_gpiod); + if (status != -EPROBE_DEFER) + dev_err(&pdev->dev, "failed to get id gpio: %d\n", status); + return status; } palmas_usb->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus",