From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A57C11D05 for ; Thu, 20 Feb 2020 16:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95B7420659 for ; Thu, 20 Feb 2020 16:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728384AbgBTQUQ (ORCPT ); Thu, 20 Feb 2020 11:20:16 -0500 Received: from muru.com ([72.249.23.125]:56326 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727868AbgBTQUP (ORCPT ); Thu, 20 Feb 2020 11:20:15 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C46C78080; Thu, 20 Feb 2020 16:20:59 +0000 (UTC) Date: Thu, 20 Feb 2020 08:20:12 -0800 From: Tony Lindgren To: "Andrew F. Davis" Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, kbuild test robot , linux-omap@vger.kernel.org Subject: Re: omap-secure.c:undefined reference to `__arm_smccc_smc' Message-ID: <20200220162012.GI37466@atomide.com> References: <202002131856.VeW4PhBJ%lkp@intel.com> <20200220155429.GH37466@atomide.com> <55ddcd29-ed8b-529e-dd54-cbac5cf74e42@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55ddcd29-ed8b-529e-dd54-cbac5cf74e42@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Andrew F. Davis [200220 16:04]: > On 2/20/20 10:54 AM, Tony Lindgren wrote: > > Andrew, > > > > * kbuild test robot [200213 10:27]: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > >> head: 0bf999f9c5e74c7ecf9dafb527146601e5c848b9 > >> commit: c37baa06f8a970e4a533d41f7d33e5e57de5ad25 ARM: OMAP2+: Fix undefined reference to omap_secure_init > >> date: 3 weeks ago > >> config: arm-randconfig-a001-20200213 (attached as .config) > >> compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 > >> reproduce: > >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >> chmod +x ~/bin/make.cross > >> git checkout c37baa06f8a970e4a533d41f7d33e5e57de5ad25 > >> # save the attached .config to linux build tree > >> GCC_VERSION=7.5.0 make.cross ARCH=arm > >> > >> If you fix the issue, kindly add following tag > >> Reported-by: kbuild test robot > >> > >> All errors (new ones prefixed by >>): > >> > >> arch/arm/mach-omap2/omap-secure.o: In function `omap_smccc_smc': > >>>> omap-secure.c:(.text+0x94): undefined reference to `__arm_smccc_smc' > > > > Have you looked at this one? Looks like there's still an unhandled > > randconfig build case. > > > > > I've had a quick look, all the ARM config does: > > select HAVE_ARM_SMCCC if CPU_V7 > > so I don't think this will happen in any real config, but if we want to > prevent randconfig issue this we could force ARCH_OMAP2PLUS to "depend" > on it. Seems to happen at least with omap2 only config where we don't have CPU_V7. Something like below seems to fix it. If that looks OK to you, I'll send out a proper fix. Regards, Tony 8< ----------------------- diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c --- a/arch/arm/mach-omap2/omap-secure.c +++ b/arch/arm/mach-omap2/omap-secure.c @@ -77,6 +77,7 @@ u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2, return ret; } +#ifdef CONFIG_HAVE_ARM_SMCCC void omap_smccc_smc(u32 fn, u32 arg) { struct arm_smccc_res res; @@ -85,6 +86,11 @@ void omap_smccc_smc(u32 fn, u32 arg) 0, 0, 0, 0, 0, 0, &res); WARN(res.a0, "Secure function call 0x%08x failed\n", fn); } +#else +void omap_smccc_smc(u32 fn, u32 arg) +{ +} +#endif void omap_smc1(u32 fn, u32 arg) {