Re: [RFC PATCH] pinctrl-single: parse #pinctrl-cells = 2

[Tony Lindgren <tony@atomide.com>]

* Drew Fustini <drew@beagleboard.org> [200616 16:54]:
> By register masks, do you mean the #define's like PIN_OUTPUT_PULLDOWN
> and MUX_MODE6?
> 
> AM33XX_PADCONF(AM335X_PIN_GPMC_A2, PIN_OUTPUT_PULLDOWN, MUX_MODE6)
> 
> There is a possibility to also use the pinconf properties defined in
> pinctrl-single.c:
> 
> 	static const struct pcs_conf_type prop2[] = {
> 		{ "pinctrl-single,drive-strength", PIN_CONFIG_DRIVE_STRENGTH, },
> 		{ "pinctrl-single,slew-rate", PIN_CONFIG_SLEW_RATE, },
> 		{ "pinctrl-single,input-schmitt", PIN_CONFIG_INPUT_SCHMITT, },
> 		{ "pinctrl-single,low-power-mode", PIN_CONFIG_LOW_POWER_MODE, },
> 	};
> 	static const struct pcs_conf_type prop4[] = {
> 		{ "pinctrl-single,bias-pullup", PIN_CONFIG_BIAS_PULL_UP, },
> 		{ "pinctrl-single,bias-pulldown", PIN_CONFIG_BIAS_PULL_DOWN, },
> 		{ "pinctrl-single,input-schmitt-enable",
> 			PIN_CONFIG_INPUT_SCHMITT_ENABLE, },
> 	};

Oh right I forgot about that :)

> I did some testing with pr_info's sprinkled in and I think those values
> are correct but I would be happy to hear from someone with more insight
> in the design of bias-pulldown and bias-pullup.

OK thanks for testing with the pinconf properties.

Regards,

Tony