From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93883C433ED for ; Thu, 23 Jul 2020 09:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E5132071A for ; Thu, 23 Jul 2020 09:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595494957; bh=A1/NZN1b6GRDNmLFWoqZmFBxBOjK9UFA3Dm2gU+YYYs=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:List-ID: From; b=N6a947T9iJrVuWN5tHMsFemdIGywbA0zUQQHz4CDNqZvEtq8h0Nar6iCDyrnL9gx2 Dle9vnsTLQ0nSKOctqiTYDwSwgCtcBz9i9Q1286yahOd7AmdNs5xGmm7fvUDzkmKhJ 0Cxq6lv9yU446F7gsLXLjrsdalzvRYyrBZRyhgJw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728114AbgGWJCg (ORCPT ); Thu, 23 Jul 2020 05:02:36 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:41843 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbgGWJCg (ORCPT ); Thu, 23 Jul 2020 05:02:36 -0400 Received: by mail-ej1-f66.google.com with SMTP id w9so5537841ejc.8; Thu, 23 Jul 2020 02:02:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SP17WTfOStR1f/zhDqqAukFagjGeQ43CPtbR6JVcAtM=; b=UdMAGS5GV336AvtRObsuflGMGwCjBEL+RzCvWzaYHkdtqcCoSTrPi/NtGi/IAy/hhP GageRiGOPKFk9XDwzHE3i1+UCqz8BMxqdB9gaBfIiAmqrnNNiHZkUM8JVUGuhPiUOKH4 i0AzKumvJZVxkBwnt0vSY4imORUqAi3MhkJ018qbtHaEufuVZAtTmoDJ6fLG9HB0OZvt lHEtGiq90LKZe07vtX8GoQkgBXdMtwo5xtUMmoVe2fButxFQUqTktUY41X8/rWMU+Ojs N+afj2e1qA2uOga344gpUM/6G05xtRvERu6VRtfiYdj2enj20a75qWXQvaCbAKBbHkR0 JGBA== X-Gm-Message-State: AOAM531Ys0J7iyz7qM8Tgcz8HTOiQ72mPCD2HzkJP7Yoqczrle2XcjHy rPuj+ZOAMEZYQlnxUOsZq0g= X-Google-Smtp-Source: ABdhPJzZvryybJpj7wOJimQ2Cyt/LNy/AugUNbqr7zzcp389gJSHaS+UZayp1LGVwYwITNeIoG5eTA== X-Received: by 2002:a17:906:57c5:: with SMTP id u5mr3270775ejr.311.1595494953946; Thu, 23 Jul 2020 02:02:33 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id h8sm660427edv.28.2020.07.23.02.02.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Jul 2020 02:02:33 -0700 (PDT) Date: Thu, 23 Jul 2020 11:02:30 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann List-Id: Cc: Olof Johansson , arm-soc , SoC Team , Markus Mayer , bcm-kernel-feedback-list , Florian Fainelli , Santosh Shilimkar , Matthias Brugger , Roger Quadros , Tony Lindgren , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , "linux-kernel@vger.kernel.org" , Linux ARM , "moderated list:ARM/Mediatek SoC..." , linux-omap , "open list:TEGRA ARCHITECTURE SUPPORT" , Andrew Morton , Linus Torvalds , Greg Kroah-Hartman Subject: Re: [PATCH 14/23] memory: ti-emif-pm: Fix cast to iomem pointer Message-ID: <20200723090230.GB25935@kozik-lap> References: <20200723073744.13400-1-krzk@kernel.org> <20200723073744.13400-15-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, Jul 23, 2020 at 10:48:19AM +0200, Arnd Bergmann wrote: > On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski wrote: > > > > Cast pointer to iomem memory properly to fix sparse warning: > > > > drivers/memory/ti-emif-pm.c:251:38: warning: incorrect type in argument 1 (different address spaces) > > drivers/memory/ti-emif-pm.c:251:38: expected void const volatile [noderef] __iomem *addr > > drivers/memory/ti-emif-pm.c:251:38: got void * > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > drivers/memory/ti-emif-pm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c > > index 9c90f815ad3a..6c747c1e98cb 100644 > > --- a/drivers/memory/ti-emif-pm.c > > +++ b/drivers/memory/ti-emif-pm.c > > @@ -248,7 +248,7 @@ MODULE_DEVICE_TABLE(of, ti_emif_of_match); > > static int ti_emif_resume(struct device *dev) > > { > > unsigned long tmp = > > - __raw_readl((void *)emif_instance->ti_emif_sram_virt); > > + __raw_readl((void __iomem *)emif_instance->ti_emif_sram_virt); > > > > Maybe this shouldn't even be __raw_readl(), but instead READ_ONCE()? Won't readl() be enough? Indeed it looks problematic. > > The other accesses in this file don't use MMIO wrappers either but just treat > it as a pointer. The effect would be the same though. I think all the reads and writes are with readl() and writel(). Best regards, Krzysztof