From: Tony Lindgren <tony@atomide.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: Slow booting on x15
Date: Thu, 24 Sep 2020 08:42:20 +0300 [thread overview]
Message-ID: <20200924054220.GA9471@atomide.com> (raw)
In-Reply-To: <20200923111346.GA3980@pendragon.ideasonboard.com>
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [200923 11:14]:
> Hi Tony,
>
> On Wed, Sep 23, 2020 at 10:07:58AM +0300, Tony Lindgren wrote:
> > * Laurent Pinchart [200918 15:59]:
> > > On Fri, Sep 18, 2020 at 06:25:02PM +0300, Tomi Valkeinen wrote:
> > > > Hi,
> > > >
> > > > Has anyone noticed that booting would have slowed down in 5.8 and in 5.9-rcs? I'm booting x15 with
> > > > my custom config builder, which uses omap2plus_defconfig as a base. I see:
> > > >
> > > > v5.7
> > > > [ 0.597765] cpuidle: using governor menu
> > > > [ 0.793198] No ATAGs?
> > > >
> > > > [ 9.654611] Run /sbin/init as init process
> > > >
> > > > 5.8
> > > > [ 0.616660] cpuidle: using governor menu
> > > > [ 4.439856] No ATAGs?
> > > >
> > > > [ 15.484710] Run /sbin/init as init process
> > > >
> > > > v5.9-rc5
> > > > [ 0.706165] cpuidle: using governor menu
> > > > [ 6.761812] No ATAGs?
> > > >
> > > > [ 19.522536] Run /sbin/init as init process
> > > >
> > > >
> > > > So v5.7 boots quickly, and init starts around 9.6 secs. 5.8 is much slower, and 5.9-rc5 even slower.
> > >
> > > I've tracked this down to device_link_add_missing_supplier_links()
> > > taking about 40+ms to run, for every device added to the system. Given
> > > the large number of devices, this adds up to 10s on v5.9-rc5, when
> > > called during the initial of_platform_populate().
> > >
> > > It doesn't seem there's a single culprit here (although I may have
> > > missed it), "just" lots of walks through the whole device tree that end
> > > up taking way too much time. I'm not planning to investigate this
> > > further at this point.
> >
> > Hmm so do you have some commit that causes this slowness?
>
> No, I haven't had time to bisect this.
>
> > In general, we should now be looking each device at module_init
> > time only when configured in the dts. I guess it's possible we still
> > have some extra walking of the whole device tree left but this sounds
> > like a more generic issue though and not related to the omap dts
> > conversion.
>
> There's a call to of_platform_populate() in pdata_quirks_init(), and
> that takes between 5 and 10 seconds to run, depending on the board.
If that is the issue we may be able to improve it a bit by probing
the interconnects separately for less deferred probe cases.
Regards,
Tony
next prev parent reply other threads:[~2020-09-24 5:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 15:25 Slow booting on x15 Tomi Valkeinen
2020-09-18 15:58 ` Laurent Pinchart
2020-09-23 7:07 ` Tony Lindgren
2020-09-23 11:13 ` Laurent Pinchart
2020-09-24 5:42 ` Tony Lindgren [this message]
2020-09-24 5:53 ` Tony Lindgren
2020-09-24 6:04 ` Tomi Valkeinen
2020-09-24 6:08 ` Tony Lindgren
2020-09-24 13:30 ` Laurent Pinchart
2020-09-25 11:51 ` Tony Lindgren
2020-09-25 11:58 ` Laurent Pinchart
2020-09-30 5:20 ` Tony Lindgren
2020-09-30 12:41 ` Peter Ujfalusi
2020-10-01 7:53 ` Tony Lindgren
2020-10-01 8:17 ` Tony Lindgren
2020-10-01 8:22 ` Laurent Pinchart
2020-10-01 12:56 ` Grygorii Strashko
2020-10-01 13:11 ` Geert Uytterhoeven
2020-10-01 13:49 ` Grygorii Strashko
2020-10-01 18:24 ` Saravana Kannan
2020-10-01 19:43 ` Grygorii Strashko
2020-10-01 22:22 ` Saravana Kannan
2020-10-01 22:30 ` Saravana Kannan
2020-10-01 22:38 ` Laurent Pinchart
2020-10-01 22:44 ` Saravana Kannan
2020-10-01 22:59 ` [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path Saravana Kannan
2020-10-01 23:19 ` Laurent Pinchart
2020-10-02 11:40 ` Grygorii Strashko
2020-10-02 15:03 ` Grygorii Strashko
2020-10-02 17:48 ` Saravana Kannan
2020-10-02 18:11 ` Grygorii Strashko
2020-10-02 14:07 ` Rob Herring
2020-10-02 17:51 ` Saravana Kannan
2020-10-02 17:54 ` Laurent Pinchart
2020-10-02 17:58 ` Saravana Kannan
2020-10-02 18:27 ` Laurent Pinchart
2020-10-02 18:35 ` Grygorii Strashko
2020-10-02 19:56 ` Saravana Kannan
2020-10-03 0:13 ` Laurent Pinchart
2020-10-27 3:29 ` Saravana Kannan
2020-10-28 7:34 ` Tomi Valkeinen
2020-10-02 20:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924054220.GA9471@atomide.com \
--to=tony@atomide.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox