Re: [PATCH v3 35/56] drm/omap: dsi: implement check timings

Tomi Valkeinen
2020-11-11T12:36:18Z

On 09/11/2020 12:47, Laurent Pinchart wrote:
> Hi Tomi and Sebastian,
>
> Thank you for the patch.
>
> On Thu, Nov 05, 2020 at 02:03:12PM +0200, Tomi Valkeinen wrote:
>> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>>
>> Implement check timings, which will check if its possible to
>
> s/its/it's/
>
>> configure the clocks for the provided mode using the same code
>> as the set_config() hook.
>>
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>> drivers/gpu/drm/omapdrm/dss/dsi.c | 70 +++++++++++++++++++------------
>> 1 file changed, 44 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
>> index a1a867a7d91d..f643321434e9 100644
>> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
>> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
>> @@ -280,6 +280,11 @@ struct dsi_isr_tables {
>> struct dsi_isr_data isr_table_cio[DSI_MAX_NR_ISRS];
>> };
>>
>> +struct dsi_lp_clock_info {
>> + unsigned long lp_clk;
>> + u16 lp_clk_div;
>> +};
>> +
>> struct dsi_clk_calc_ctx {
>> struct dsi_data *dsi;
>> struct dss_pll *pll;
>> @@ -294,16 +299,12 @@ struct dsi_clk_calc_ctx {
>>
>> struct dss_pll_clock_info dsi_cinfo;
>> struct dispc_clock_info dispc_cinfo;
>> + struct dsi_lp_clock_info user_lp_cinfo;
>
> Any reason for the user_ prefix here ?

No, I'll drop it.

Tomi