From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544A0C388F2 for ; Fri, 6 Nov 2020 04:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 947B620719 for ; Fri, 6 Nov 2020 04:50:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZcXoNqHF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725828AbgKFEuI (ORCPT ); Thu, 5 Nov 2020 23:50:08 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:60126 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbgKFEuI (ORCPT ); Thu, 5 Nov 2020 23:50:08 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EA328B16; Fri, 6 Nov 2020 05:50:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604638206; bh=mWGcTscioAhu2GB1EWb2T9azei10YT3QsM4gehU3Vm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZcXoNqHF2c+zB9zadFN7pwtipV26qOj9odsOeTNN5t3ZcqpvFJmIcERJaYdmWxsnU w0ykIlntuhOUdF2H9pGeSEqBubyYNKeXCrMq/b/WWJ3Lw4kbzKU8Lms1CIE7P4fRPz zHaxJPxN7mF5DrqZp5PhM17uHu+ML6Zqn1CbiXK4= Date: Fri, 6 Nov 2020 06:50:04 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel Subject: Re: [PATCH v3 02/56] Revert "drm/omap: dss: Remove unused omap_dss_device operations" Message-ID: <20201106045004.GC16469@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-3-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-3-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi and Sebastian, Thank you for the patch. On Thu, Nov 05, 2020 at 02:02:39PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > This reverts commit 4ff8e98879e6eeae9d125dfcf3b642075d00089d. With this fixed as requested by Sam, Reviewed-by: Laurent Pinchart > This is still needed by DSI. E.g. unloading modules without this will > cause a crash. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/dss/base.c | 26 +++++++++++++++ > drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 ++++ > drivers/gpu/drm/omapdrm/omap_encoder.c | 44 +++++++++++++++++++++++--- > 3 files changed, 71 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/base.c b/drivers/gpu/drm/omapdrm/dss/base.c > index c7650a7c155d..455b410f7401 100644 > --- a/drivers/gpu/drm/omapdrm/dss/base.c > +++ b/drivers/gpu/drm/omapdrm/dss/base.c > @@ -234,6 +234,18 @@ void omapdss_device_disconnect(struct omap_dss_device *src, > } > EXPORT_SYMBOL_GPL(omapdss_device_disconnect); > > +void omapdss_device_pre_enable(struct omap_dss_device *dssdev) > +{ > + if (!dssdev) > + return; > + > + omapdss_device_pre_enable(dssdev->next); > + > + if (dssdev->ops && dssdev->ops->pre_enable) > + dssdev->ops->pre_enable(dssdev); > +} > +EXPORT_SYMBOL_GPL(omapdss_device_pre_enable); > + > void omapdss_device_enable(struct omap_dss_device *dssdev) > { > if (!dssdev) > @@ -260,6 +272,20 @@ void omapdss_device_disable(struct omap_dss_device *dssdev) > } > EXPORT_SYMBOL_GPL(omapdss_device_disable); > > +void omapdss_device_post_disable(struct omap_dss_device *dssdev) > +{ > + if (!dssdev) > + return; > + > + if (dssdev->ops && dssdev->ops->post_disable) > + dssdev->ops->post_disable(dssdev); > + > + omapdss_device_post_disable(dssdev->next); > + > + dssdev->state = OMAP_DSS_DISPLAY_DISABLED; > +} > +EXPORT_SYMBOL_GPL(omapdss_device_post_disable); > + > /* ----------------------------------------------------------------------------- > * Components Handling > */ > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index ab19d4af8de7..cbbe10b2b60d 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -342,11 +342,15 @@ struct omap_dss_device_ops { > void (*disconnect)(struct omap_dss_device *dssdev, > struct omap_dss_device *dst); > > + void (*pre_enable)(struct omap_dss_device *dssdev); > void (*enable)(struct omap_dss_device *dssdev); > void (*disable)(struct omap_dss_device *dssdev); > + void (*post_disable)(struct omap_dss_device *dssdev); > > int (*check_timings)(struct omap_dss_device *dssdev, > struct drm_display_mode *mode); > + void (*set_timings)(struct omap_dss_device *dssdev, > + const struct drm_display_mode *mode); > > int (*get_modes)(struct omap_dss_device *dssdev, > struct drm_connector *connector); > @@ -445,8 +449,10 @@ int omapdss_device_connect(struct dss_device *dss, > struct omap_dss_device *dst); > void omapdss_device_disconnect(struct omap_dss_device *src, > struct omap_dss_device *dst); > +void omapdss_device_pre_enable(struct omap_dss_device *dssdev); > void omapdss_device_enable(struct omap_dss_device *dssdev); > void omapdss_device_disable(struct omap_dss_device *dssdev); > +void omapdss_device_post_disable(struct omap_dss_device *dssdev); > > int omap_dss_get_num_overlay_managers(void); > > diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_encoder.c > index ae4b867a67a3..18a79dde6815 100644 > --- a/drivers/gpu/drm/omapdrm/omap_encoder.c > +++ b/drivers/gpu/drm/omapdrm/omap_encoder.c > @@ -113,8 +113,13 @@ static void omap_encoder_mode_set(struct drm_encoder *encoder, > bus_flags = connector->display_info.bus_flags; > omap_encoder_update_videomode_flags(&vm, bus_flags); > > - /* Set timings for the dss manager. */ > + /* Set timings for all devices in the display pipeline. */ > dss_mgr_set_timings(output, &vm); > + > + for (dssdev = output; dssdev; dssdev = dssdev->next) { > + if (dssdev->ops && dssdev->ops->set_timings) > + dssdev->ops->set_timings(dssdev, adjusted_mode); > + } > } > > static void omap_encoder_disable(struct drm_encoder *encoder) > @@ -127,10 +132,26 @@ static void omap_encoder_disable(struct drm_encoder *encoder) > > /* > * Disable the chain of external devices, starting at the one at the > - * internal encoder's output. This is used for DSI outputs only, as > - * dssdev->next is NULL for all other outputs. > + * internal encoder's output. > */ > omapdss_device_disable(dssdev->next); > + > + /* > + * Disable the internal encoder. This will disable the DSS output. The > + * DSI is treated as an exception as DSI pipelines still use the legacy > + * flow where the pipeline output controls the encoder. > + */ > + if (dssdev->type != OMAP_DISPLAY_TYPE_DSI) { > + if (dssdev->ops && dssdev->ops->disable) > + dssdev->ops->disable(dssdev); > + dssdev->state = OMAP_DSS_DISPLAY_DISABLED; > + } > + > + /* > + * Perform the post-disable operations on the chain of external devices > + * to complete the display pipeline disable. > + */ > + omapdss_device_post_disable(dssdev->next); > } > > static void omap_encoder_enable(struct drm_encoder *encoder) > @@ -141,10 +162,23 @@ static void omap_encoder_enable(struct drm_encoder *encoder) > > dev_dbg(dev->dev, "enable(%s)\n", dssdev->name); > > + /* Prepare the chain of external devices for pipeline enable. */ > + omapdss_device_pre_enable(dssdev->next); > + > + /* > + * Enable the internal encoder. This will enable the DSS output. The > + * DSI is treated as an exception as DSI pipelines still use the legacy > + * flow where the pipeline output controls the encoder. > + */ > + if (dssdev->type != OMAP_DISPLAY_TYPE_DSI) { > + if (dssdev->ops && dssdev->ops->enable) > + dssdev->ops->enable(dssdev); > + dssdev->state = OMAP_DSS_DISPLAY_ACTIVE; > + } > + > /* > * Enable the chain of external devices, starting at the one at the > - * internal encoder's output. This is used for DSI outputs only, as > - * dssdev->next is NULL for all other outputs. > + * internal encoder's output. > */ > omapdss_device_enable(dssdev->next); > } -- Regards, Laurent Pinchart