Re: [PATCH v3 47/56] drm/omap: drop DSS ops_flags

Laurent Pinchart
2020-11-09T11:05:59Z

Hi Tomi and Sebastian,

Thank you for the patch.

On Thu, Nov 05, 2020 at 02:03:24PM +0200, Tomi Valkeinen wrote:
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> The omapdss device's ops_flags field is no longer
> used and can be dropped.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 ---------
> drivers/gpu/drm/omapdrm/dss/venc.c | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index 1f02d3e406dc..916c55101629 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -279,14 +279,6 @@ struct omap_dss_device_ops {
> const struct omapdss_dsi_ops dsi;
> };
>
> -/**
> - * enum omap_dss_device_ops_flag - Indicates which device ops are supported
> - * @OMAP_DSS_DEVICE_OP_MODES: The device supports reading modes
> - */
> -enum omap_dss_device_ops_flag {
> - OMAP_DSS_DEVICE_OP_MODES = BIT(3),
> -};
> -
> struct omap_dss_device {
> struct device *dev;
>
> @@ -315,7 +307,6 @@ struct omap_dss_device {
> const char *name;
>
> const struct omap_dss_device_ops *ops;
> - unsigned long ops_flags;
> u32 bus_flags;
>
> /* OMAP DSS output specific fields */
> diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
> index 5c027c81760f..6e418a0f7572 100644
> --- a/drivers/gpu/drm/omapdrm/dss/venc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/venc.c
> @@ -732,7 +732,6 @@ static int venc_init_output(struct venc_device *venc)
> out->dispc_channel = OMAP_DSS_CHANNEL_DIGIT;
> out->owner = THIS_MODULE;
> out->of_port = 0;
> - out->ops_flags = OMAP_DSS_DEVICE_OP_MODES;
>
> r = omapdss_device_init_output(out, &venc->bridge);
> if (r < 0) {

--
Regards,

Laurent Pinchart