From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DD1C55ABD for ; Mon, 9 Nov 2020 08:10:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6475C221FB for ; Mon, 9 Nov 2020 08:10:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OfZxQVAP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbgKIIK1 (ORCPT ); Mon, 9 Nov 2020 03:10:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727679AbgKIIK1 (ORCPT ); Mon, 9 Nov 2020 03:10:27 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 031D2C0613CF for ; Mon, 9 Nov 2020 00:10:27 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 46E72B2B; Mon, 9 Nov 2020 09:10:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604909421; bh=PZP1TENW/bWXLV9kzd8X0zuGpseuJt2ASzL6VnVr07U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OfZxQVAP38lMiRKBv7jFttEJruV9cgdr6R4Mqy1hWI6PIOCWLLpUnk8/K2gKIZddi 7EVoFN4uYu/sGJns4vlXeiW7m2vrehvbhiwgB7iGVp5XdtdhWMNMZDR1MNx9Lwsr7P AWBhHMpenvXk87rwFgGcJOmc1NfegAUyQnMWLdl0= Date: Mon, 9 Nov 2020 10:10:17 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel Subject: Re: [PATCH v3 08/56] drm/omap: dsi: unexport specific data transfer functions Message-ID: <20201109081017.GD6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-9-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-9-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi and Sebastian, Thank you for the patch. On Thu, Nov 05, 2020 at 02:02:45PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > After converting all DSI drivers, unexport the specific transfer > functions. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 12 ------------ > drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 -------------------- > 2 files changed, 32 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 59a62d1d41cb..2270730b16db 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -4949,18 +4949,6 @@ static const struct omap_dss_device_ops dsi_ops = { > .release_vc = dsi_release_vc, > > .transfer = omap_dsi_transfer, > - > - .dcs_write = dsi_vc_dcs_write, > - .dcs_write_nosync = dsi_vc_dcs_write_nosync, > - .dcs_read = dsi_vc_dcs_read, > - > - .gen_write = dsi_vc_generic_write, > - .gen_write_nosync = dsi_vc_generic_write_nosync, > - .gen_read = dsi_vc_generic_read, > - > - .bta_sync = dsi_vc_send_bta_sync, > - > - .set_max_rx_packet_size = dsi_vc_set_max_rx_packet_size, > }, > }; > > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index 654618e5a4e5..9ead877cb24c 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -310,26 +310,6 @@ struct omapdss_dsi_ops { > /* data transfer */ > ssize_t (*transfer)(struct omap_dss_device *dssdev, > const struct mipi_dsi_msg *msg); > - > - int (*dcs_write)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*dcs_write_nosync)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*dcs_read)(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd, > - u8 *data, int len); > - > - int (*gen_write)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*gen_write_nosync)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*gen_read)(struct omap_dss_device *dssdev, int channel, > - const u8 *reqdata, int reqlen, > - u8 *data, int len); > - > - int (*bta_sync)(struct omap_dss_device *dssdev, int channel); > - > - int (*set_max_rx_packet_size)(struct omap_dss_device *dssdev, > - int channel, u16 plen); > }; > > struct omap_dss_device_ops { -- Regards, Laurent Pinchart