From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FA0DC2D0A3 for ; Mon, 9 Nov 2020 08:43:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3286B20719 for ; Mon, 9 Nov 2020 08:43:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FstiZFcP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726176AbgKIInS (ORCPT ); Mon, 9 Nov 2020 03:43:18 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39548 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgKIInS (ORCPT ); Mon, 9 Nov 2020 03:43:18 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 18BA22FE; Mon, 9 Nov 2020 09:43:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604911396; bh=KwRODhIebC+oWDoE1zteNZmvETpiVVaiebNWpV3Dydo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FstiZFcPdO1sAdGO0DNLYnfkP7UHxlhYATejgxiSly7Gu+//hON7vuiYlnxvX05bl 4fCPI4zPe/1jz6nAplkxVJM5deixPzDWlZ/6pZ0ZB3s/H6ugCs7DuW7o6Ym43UEvlJ JWKK/ZIHPfv7IAOUi946tVg6hwzYgLE+CQZ8ZozU= Date: Mon, 9 Nov 2020 10:43:12 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel Subject: Re: [PATCH v3 16/56] drm/omap: panel-dsi-cm: drop hardcoded VC Message-ID: <20201109084312.GM6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-17-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-17-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, Thank you for the patch. On Thu, Nov 05, 2020 at 02:02:53PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > Use dsi->channel everywhere, which originates from DT. I'm not sure DT is the right place to provide this information, but that's an issue broader than this patch series. Reviewed-by: Laurent Pinchart > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen > --- > .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 20 +++++++------------ > 1 file changed, 7 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > index b1ca9b34ce17..25183744a61d 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -27,9 +27,6 @@ > > #include "../dss/omapdss.h" > > -/* DSI Virtual channel. Hardcoded for now. */ > -#define TCH 0 > - > #define DCS_READ_NUM_ERRORS 0x05 > #define DCS_BRIGHTNESS 0x51 > #define DCS_CTRL_DISPLAY 0x53 > @@ -73,7 +70,6 @@ struct panel_drv_data { > bool te_enabled; > > atomic_t do_update; > - int channel; > > struct delayed_work te_timeout_work; > > @@ -274,7 +270,7 @@ static int dsicm_exit_ulps(struct panel_drv_data *ddata) > return 0; > > src->ops->enable(src); > - src->ops->dsi.enable_hs(src, ddata->channel, true); > + src->ops->dsi.enable_hs(src, ddata->dsi->channel, true); > > r = _dsicm_enable_te(ddata, true); > if (r) { > @@ -591,7 +587,7 @@ static int dsicm_power_on(struct panel_drv_data *ddata) > > dsicm_hw_reset(ddata); > > - src->ops->dsi.enable_hs(src, ddata->channel, false); > + src->ops->dsi.enable_hs(src, ddata->dsi->channel, false); > > r = dsicm_sleep_out(ddata); > if (r) > @@ -622,7 +618,7 @@ static int dsicm_power_on(struct panel_drv_data *ddata) > if (r) > goto err; > > - r = src->ops->dsi.enable_video_output(src, ddata->channel); > + r = src->ops->dsi.enable_video_output(src, ddata->dsi->channel); > if (r) > goto err; > > @@ -634,7 +630,7 @@ static int dsicm_power_on(struct panel_drv_data *ddata) > ddata->intro_printed = true; > } > > - src->ops->dsi.enable_hs(src, ddata->channel, true); > + src->ops->dsi.enable_hs(src, ddata->dsi->channel, true); > > return 0; > err: > @@ -658,7 +654,7 @@ static void dsicm_power_off(struct panel_drv_data *ddata) > struct omap_dss_device *src = ddata->src; > int r; > > - src->ops->dsi.disable_video_output(src, ddata->channel); > + src->ops->dsi.disable_video_output(src, ddata->dsi->channel); > > r = mipi_dsi_dcs_set_display_off(ddata->dsi); > if (!r) > @@ -777,7 +773,7 @@ static irqreturn_t dsicm_te_isr(int irq, void *data) > if (old) { > cancel_delayed_work(&ddata->te_timeout_work); > > - r = src->ops->dsi.update(src, ddata->channel, dsicm_framedone_cb, > + r = src->ops->dsi.update(src, ddata->dsi->channel, dsicm_framedone_cb, > ddata); > if (r) > goto err; > @@ -834,7 +830,7 @@ static int dsicm_update(struct omap_dss_device *dssdev, > msecs_to_jiffies(250)); > atomic_set(&ddata->do_update, 1); > } else { > - r = src->ops->dsi.update(src, ddata->channel, dsicm_framedone_cb, > + r = src->ops->dsi.update(src, ddata->dsi->channel, dsicm_framedone_cb, > ddata); > if (r) > goto err; > @@ -1110,8 +1106,6 @@ static int dsicm_probe_of(struct mipi_dsi_device *dsi) > struct display_timing timing; > int err; > > - ddata->channel = TCH; > - > ddata->reset_gpio = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > if (IS_ERR(ddata->reset_gpio)) { > err = PTR_ERR(ddata->reset_gpio); -- Regards, Laurent Pinchart