From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EBDC2D0A3 for ; Mon, 9 Nov 2020 10:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BDBA2080C for ; Mon, 9 Nov 2020 10:49:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NYfDuXIR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbgKIKto (ORCPT ); Mon, 9 Nov 2020 05:49:44 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:40942 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727303AbgKIKto (ORCPT ); Mon, 9 Nov 2020 05:49:44 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 12F38B2B; Mon, 9 Nov 2020 11:49:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604918983; bh=7n9Yat1LWWRbM/MHFdHEdgdkx/EI6U1p1Djt3qGtJ/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NYfDuXIR1o6F1exG7Fs5IxNCYfHhiu+dNJgw81gLix9699bqnzy/jVn5ozxQ3uFEV fU6w/tR4TXc+sbNgDtRiGGl8Fqycz6smegn5qwEyg3lunFjyTZXSYRuZPg9cZ6gv48 2HGMUnx+pVgY7Jf4BwShCSXHOs6nRWV3ETtBlzNo= Date: Mon, 9 Nov 2020 12:49:39 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel Subject: Re: [PATCH v3 37/56] drm/omap: panel-dsi-cm: support unbinding Message-ID: <20201109104939.GH6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-38-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-38-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi and Sebastian, On Thu, Nov 05, 2020 at 02:03:14PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > Now, that the driver implements the common DRM panel API > the unbind no longer needs to be suppressed. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen Acked-by: Laurent Pinchart I'd be curious to know what happens when you try to unbind through sysfs though... > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > index 5159dd51a353..086c7d71fe17 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -607,7 +607,7 @@ static int dsicm_probe(struct mipi_dsi_device *dsi) > return r; > } > > -static int __exit dsicm_remove(struct mipi_dsi_device *dsi) > +static int dsicm_remove(struct mipi_dsi_device *dsi) > { > struct panel_drv_data *ddata = mipi_dsi_get_drvdata(dsi); > > @@ -637,11 +637,10 @@ MODULE_DEVICE_TABLE(of, dsicm_of_match); > > static struct mipi_dsi_driver dsicm_driver = { > .probe = dsicm_probe, > - .remove = __exit_p(dsicm_remove), > + .remove = dsicm_remove, > .driver = { > .name = "panel-dsi-cm", > .of_match_table = dsicm_of_match, > - .suppress_bind_attrs = true, > }, > }; > module_mipi_dsi_driver(dsicm_driver); -- Regards, Laurent Pinchart