From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B126C2D0A3 for ; Mon, 9 Nov 2020 11:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EDF4216C4 for ; Mon, 9 Nov 2020 11:03:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TBWYK2L8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729168AbgKILDs (ORCPT ); Mon, 9 Nov 2020 06:03:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbgKILDs (ORCPT ); Mon, 9 Nov 2020 06:03:48 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05F7FC0613CF for ; Mon, 9 Nov 2020 03:03:48 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EC70B2B; Mon, 9 Nov 2020 12:03:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604919826; bh=b+vOTMVp88TQXSCdD0UnHPHbMtdpOOe+ETl+qP/YvDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TBWYK2L8X5PP28HSZyIJShwmBW+xzBquRnbIvtLgo5cLA/Z4wM5OIYMptLFVJ1d7X Qfr0uqWTQb7y1Sv81bJnfCwSTjC75EKN9By/mc57ljWtrYiB80b/+g0kLKdh0ySlJu Ms02fzDtBz4wZXHvLt5Ob7gWodr+Z5OHqEJvF5P4= Date: Mon, 9 Nov 2020 13:03:43 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel Subject: Re: [PATCH v3 44/56] drm/omap: simplify omap_display_id Message-ID: <20201109110343.GO6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-45-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-45-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi and Sebastian, Thank you for the patch. On Thu, Nov 05, 2020 at 02:03:21PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > We no longer need to check for the DSS API, since all encoders, > panels and connectors have been converted to the bridge API. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c > index 20b5b4e9071c..dbb8e95234b3 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -206,14 +206,7 @@ static int omap_display_id(struct omap_dss_device *output) > { > struct device_node *node = NULL; > > - if (output->next) { > - struct omap_dss_device *display = output; > - > - while (display->next) > - display = display->next; > - > - node = display->dev->of_node; > - } else if (output->bridge) { > + if (output->bridge) { > struct drm_bridge *bridge = output->bridge; > > while (drm_bridge_get_next_bridge(bridge)) > -- Regards, Laurent Pinchart