Re: [PATCH v3 08/56] drm/omap: dsi: unexport specific data transfer functions

Laurent Pinchart
2020-11-09T08:10:29Z

Hi Tomi and Sebastian,

Thank you for the patch.

On Thu, Nov 05, 2020 at 02:02:45PM +0200, Tomi Valkeinen wrote:
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> After converting all DSI drivers, unexport the specific transfer
> functions.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/gpu/drm/omapdrm/dss/dsi.c | 12 ------------
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 --------------------
> 2 files changed, 32 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 59a62d1d41cb..2270730b16db 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -4949,18 +4949,6 @@ static const struct omap_dss_device_ops dsi_ops = {
> .release_vc = dsi_release_vc,
>
> .transfer = omap_dsi_transfer,
> -
> - .dcs_write = dsi_vc_dcs_write,
> - .dcs_write_nosync = dsi_vc_dcs_write_nosync,
> - .dcs_read = dsi_vc_dcs_read,
> -
> - .gen_write = dsi_vc_generic_write,
> - .gen_write_nosync = dsi_vc_generic_write_nosync,
> - .gen_read = dsi_vc_generic_read,
> -
> - .bta_sync = dsi_vc_send_bta_sync,
> -
> - .set_max_rx_packet_size = dsi_vc_set_max_rx_packet_size,
> },
> };
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index 654618e5a4e5..9ead877cb24c 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -310,26 +310,6 @@ struct omapdss_dsi_ops {
> /* data transfer */
> ssize_t (*transfer)(struct omap_dss_device *dssdev,
> const struct mipi_dsi_msg *msg);
> -
> - int (*dcs_write)(struct omap_dss_device *dssdev, int channel,
> - const u8 *data, int len);
> - int (*dcs_write_nosync)(struct omap_dss_device *dssdev, int channel,
> - const u8 *data, int len);
> - int (*dcs_read)(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd,
> - u8 *data, int len);
> -
> - int (*gen_write)(struct omap_dss_device *dssdev, int channel,
> - const u8 *data, int len);
> - int (*gen_write_nosync)(struct omap_dss_device *dssdev, int channel,
> - const u8 *data, int len);
> - int (*gen_read)(struct omap_dss_device *dssdev, int channel,
> - const u8 *reqdata, int reqlen,
> - u8 *data, int len);
> -
> - int (*bta_sync)(struct omap_dss_device *dssdev, int channel);
> -
> - int (*set_max_rx_packet_size)(struct omap_dss_device *dssdev,
> - int channel, u16 plen);
> };
>
> struct omap_dss_device_ops {

--
Regards,

Laurent Pinchart