From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E17C388F7 for ; Mon, 9 Nov 2020 11:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E1742084C for ; Mon, 9 Nov 2020 11:16:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WaUQU2SF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgKILQt (ORCPT ); Mon, 9 Nov 2020 06:16:49 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:41562 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729302AbgKILQs (ORCPT ); Mon, 9 Nov 2020 06:16:48 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F1C03B2B; Mon, 9 Nov 2020 12:16:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604920606; bh=29no4bJHGKquWNGhM39BN9pSSKpkZJcY9FVEFgvsPl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WaUQU2SF88JaB9FMaF+77CQEOK0bFITXV8K9ajN/EylAjm6JCDCyoijd4j+SOfz5u boGxY+jVue4APKgR0trwAl1NMknNhcY/cS74At8UzwvoFDvlzU2KMUDjVTHfMbR6wa FGRIbTG+4VZihlcbe3Njqa82RTkSdCDzblgEze4g= Date: Mon, 9 Nov 2020 13:16:41 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" Subject: Re: [PATCH v3 54/56] drm/omap: drop unused owner field Message-ID: <20201109111641.GY6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-55-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-55-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, Thank you for the patch. On Thu, Nov 05, 2020 at 02:03:31PM +0200, Tomi Valkeinen wrote: > dssdev->owner is set, but never used. We can drop the field. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dpi.c | 1 - > drivers/gpu/drm/omapdrm/dss/dsi.c | 1 - > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 - > drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 -- > drivers/gpu/drm/omapdrm/dss/sdi.c | 1 - > drivers/gpu/drm/omapdrm/dss/venc.c | 1 - > 7 files changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c > index 1d2992daef40..030f997eccd0 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dpi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dpi.c > @@ -641,7 +641,6 @@ static int dpi_init_output_port(struct dpi_data *dpi, struct device_node *port) > out->type = OMAP_DISPLAY_TYPE_DPI; > out->dispc_channel = dpi_get_channel(dpi); > out->of_port = port_num; > - out->owner = THIS_MODULE; > > r = omapdss_device_init_output(out, &dpi->bridge); > if (r < 0) { > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 76e4f607d8cf..22718a771d6d 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -5443,7 +5443,6 @@ static int dsi_init_output(struct dsi_data *dsi) > out->name = dsi->module_id == 0 ? "dsi.0" : "dsi.1"; > out->dispc_channel = dsi_get_channel(dsi); > out->dsi_ops = &dsi_ops; > - out->owner = THIS_MODULE; > out->of_port = 0; > out->bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE > | DRM_BUS_FLAG_DE_HIGH > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c > index a14fbf06cb30..13701571d59b 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c > @@ -707,7 +707,6 @@ static int hdmi4_init_output(struct omap_hdmi *hdmi) > out->type = OMAP_DISPLAY_TYPE_HDMI; > out->name = "hdmi.0"; > out->dispc_channel = OMAP_DSS_CHANNEL_DIGIT; > - out->owner = THIS_MODULE; > out->of_port = 0; > > r = omapdss_device_init_output(out, &hdmi->bridge); > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c > index b738d9750686..5d627caf90f2 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c > @@ -681,7 +681,6 @@ static int hdmi5_init_output(struct omap_hdmi *hdmi) > out->type = OMAP_DISPLAY_TYPE_HDMI; > out->name = "hdmi.0"; > out->dispc_channel = OMAP_DSS_CHANNEL_DIGIT; > - out->owner = THIS_MODULE; > out->of_port = 0; > > r = omapdss_device_init_output(out, &hdmi->bridge); > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index 90e41c635e45..4442e49ffc5c 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -263,8 +263,6 @@ struct omapdss_dsi_ops { > struct omap_dss_device { > struct device *dev; > > - struct module *owner; > - > struct dss_device *dss; > struct drm_bridge *bridge; > struct drm_bridge *next_bridge; > diff --git a/drivers/gpu/drm/omapdrm/dss/sdi.c b/drivers/gpu/drm/omapdrm/dss/sdi.c > index 033fd30074b0..35827b4487bd 100644 > --- a/drivers/gpu/drm/omapdrm/dss/sdi.c > +++ b/drivers/gpu/drm/omapdrm/dss/sdi.c > @@ -314,7 +314,6 @@ static int sdi_init_output(struct sdi_device *sdi) > out->dispc_channel = OMAP_DSS_CHANNEL_LCD; > /* We have SDI only on OMAP3, where it's on port 1 */ > out->of_port = 1; > - out->owner = THIS_MODULE; > out->bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE /* 15.5.9.1.2 */ > | DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE; > > diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c > index 6e418a0f7572..8ecffe5bbd29 100644 > --- a/drivers/gpu/drm/omapdrm/dss/venc.c > +++ b/drivers/gpu/drm/omapdrm/dss/venc.c > @@ -730,7 +730,6 @@ static int venc_init_output(struct venc_device *venc) > out->type = OMAP_DISPLAY_TYPE_VENC; > out->name = "venc.0"; > out->dispc_channel = OMAP_DSS_CHANNEL_DIGIT; > - out->owner = THIS_MODULE; > out->of_port = 0; > > r = omapdss_device_init_output(out, &venc->bridge); -- Regards, Laurent Pinchart