From: Suman Anna <s-anna@ti.com>
To: Rob Herring <robh+dt@kernel.org>, Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Nishanth Menon <nm@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>,
Sekhar Nori <nsekhar@ti.com>, Jan Kiszka <jan.kiszka@siemens.com>,
David Lechner <david@lechnology.com>,
<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
Suman Anna <s-anna@ti.com>
Subject: [PATCH] dt-bindings: irqchip: Add #address-cells to PRUSS INTC
Date: Fri, 15 Jan 2021 14:58:19 -0600 [thread overview]
Message-ID: <20210115205819.19426-1-s-anna@ti.com> (raw)
The '#address-cells' property looks to be a required property for
interrupt controller nodes as indicated by a warning message seen
when building dtbs with W=2. Adding the property to the PRUSS INTC
dts nodes though fails the dtbs_check. Add this property to the
PRUSS INTC binding to make it compliant with both dtbs_check and
building dtbs.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
Hi Rob,
This patch is also part of our effort to get rid of the warnings seen
around interrupt providers on TI K3 dtbs [1]. I needed this in the PRUSS
INTC bindings to not get a warning with dtbs_check while also ensuring
no warnings while building dtbs with W=2.
I would have expected the '#address-cells' requirement to be inherited
automatically. And looking through the schema files, I actually do not
see the interrupt-controller.yaml included automatically anywhere. You
had asked us to drop the inclusion in this binding in our first version
with YAML [3]. Am I missing something, and how do we ensure that this
is enforced automatically for everyone?
regards
Suman
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115083003.27387-1-lokeshvutla@ti.com/
[2] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/
[3] https://patchwork.kernel.org/comment/23484523/
.../bindings/interrupt-controller/ti,pruss-intc.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml
index c2ce215501a5..dcbfe08e997d 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml
@@ -79,6 +79,9 @@ properties:
mapping and channels to host interrupts so through this property entire
mapping is provided.
+ "#address-cells":
+ const: 0
+
ti,irqs-reserved:
$ref: /schemas/types.yaml#/definitions/uint8
description: |
@@ -100,6 +103,7 @@ required:
- interrupt-names
- interrupt-controller
- "#interrupt-cells"
+ - "#address-cells"
additionalProperties: false
@@ -123,6 +127,7 @@ examples:
"host_intr6", "host_intr7";
interrupt-controller;
#interrupt-cells = <3>;
+ #address-cells = <0>;
};
};
@@ -142,6 +147,7 @@ examples:
reg = <0x20000 0x2000>;
interrupt-controller;
#interrupt-cells = <3>;
+ #address-cells = <0>;
interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>,
--
2.29.2
next reply other threads:[~2021-01-15 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 20:58 Suman Anna [this message]
2021-01-26 0:04 ` [PATCH] dt-bindings: irqchip: Add #address-cells to PRUSS INTC Rob Herring
2021-01-26 0:16 ` Suman Anna
2021-01-26 0:16 ` Suman Anna
2021-01-26 2:47 ` Rob Herring
2021-01-26 15:54 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115205819.19426-1-s-anna@ti.com \
--to=s-anna@ti.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=grzegorz.jaszczyk@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=maz@kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox