From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8ECC433E6 for ; Mon, 25 Jan 2021 14:44:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41A6622228 for ; Mon, 25 Jan 2021 14:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729652AbhAYOn3 (ORCPT ); Mon, 25 Jan 2021 09:43:29 -0500 Received: from m42-8.mailgun.net ([69.72.42.8]:32704 "EHLO m42-8.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729718AbhAYOnW (ORCPT ); Mon, 25 Jan 2021 09:43:22 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1611585783; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=N1G8HgYx4yjCIsYOGEiep9cAWYxAMa8NN2xd/w9uiZU=; b=FX2PG7ADXA1z2lfAgU5Y51q8QiyvxzkwS9N5D/RP72G+kBXuexu9+YxD9MZ5cXEx/d92IxIu xKvenO6uRVg6CA9z8ihKaBANL+GuMnW7EmB6dWn+JHBUJ9F/wCtZPdRzkg4XOfejoRO5OIsm OAklUsIvyMaWVvvURZwyxK8TnVQ= X-Mailgun-Sending-Ip: 69.72.42.8 X-Mailgun-Sid: WyIwZGJlNiIsICJsaW51eC1vbWFwQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 600ed8d82c36b2106d087e50 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 25 Jan 2021 14:42:32 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8D884C433ED; Mon, 25 Jan 2021 14:42:31 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A3FFCC433CA; Mon, 25 Jan 2021 14:42:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A3FFCC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCHv2 ] wlcore: Fix command execute failure 19 for wl12xx From: Kalle Valo In-Reply-To: <20210115065613.7731-1-tony@atomide.com> References: <20210115065613.7731-1-tony@atomide.com> To: Tony Lindgren Cc: Eyal Reizer , Guy Mishol , Raz Bouganim , linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210125144231.8D884C433ED@smtp.codeaurora.org> Date: Mon, 25 Jan 2021 14:42:31 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Tony Lindgren wrote: > We can currently get a "command execute failure 19" error on beacon loss > if the signal is weak: > > wlcore: Beacon loss detected. roles:0xff > wlcore: Connection loss work (role_id: 0). > ... > wlcore: ERROR command execute failure 19 > ... > WARNING: CPU: 0 PID: 1552 at drivers/net/wireless/ti/wlcore/main.c:803 > ... > (wl12xx_queue_recovery_work.part.0 [wlcore]) > (wl12xx_cmd_role_start_sta [wlcore]) > (wl1271_op_bss_info_changed [wlcore]) > (ieee80211_prep_connection [mac80211]) > > Error 19 is defined as CMD_STATUS_WRONG_NESTING from the wlcore firmware, > and seems to mean that the firmware no longer wants to see the quirk > handling for WLCORE_QUIRK_START_STA_FAILS done. > > This quirk got added with commit 18eab430700d ("wlcore: workaround > start_sta problem in wl12xx fw"), and it seems that this already got fixed > in the firmware long time ago back in 2012 as wl18xx never had this quirk > in place to start with. > > As we no longer even support firmware that early, to me it seems that it's > safe to just drop WLCORE_QUIRK_START_STA_FAILS to fix the error. Looks > like earlier firmware got disabled back in 2013 with commit 0e284c074ef9 > ("wl12xx: increase minimum singlerole firmware version required"). > > If it turns out we still need WLCORE_QUIRK_START_STA_FAILS with any > firmware that the driver works with, we can simply revert this patch and > add extra checks for firmware version used. > > With this fix wlcore reconnects properly after a beacon loss. > > Cc: Raz Bouganim > Signed-off-by: Tony Lindgren Patch applied to wireless-drivers-next.git, thanks. cb88d01b6738 wlcore: Fix command execute failure 19 for wl12xx -- https://patchwork.kernel.org/project/linux-wireless/patch/20210115065613.7731-1-tony@atomide.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches