Re: [PATCH v2 0/5] PCI: dwc: improve msi handling

Jon Hunter
2020-09-28T17:47:01Z

On 27/09/2020 09:28, Jisheng Zhang wrote:

...

> I see, the msi_domain_set_affinity() calls parent->chip->irq_set_affinity
> without checking, grepping the irqchip and pci dir, I found that
> if the MSI is based on some cascaded interrupt mechanism, they all
> point the irq_set_affinity to irq_chip_set_affinity_parent(), so I believe
> below patch works:
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index bf25d783b5c5..093fba616736 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -137,12 +137,6 @@ static void dw_pci_setup_msi_msg(struct irq_data *d, struct msi_msg *msg)
> (int)d->hwirq, msg->address_hi, msg->address_lo);
> }
>
> -static int dw_pci_msi_set_affinity(struct irq_data *d,
> - const struct cpumask *mask, bool force)
> -{
> - return -EINVAL;
> -}
> -
> static void dw_pci_bottom_mask(struct irq_data *d)
> {
> struct pcie_port *pp = irq_data_get_irq_chip_data(d);
> @@ -197,7 +191,7 @@ static struct irq_chip dw_pci_msi_bottom_irq_chip = {
> .name = "DWPCI-MSI",
> .irq_ack = dw_pci_bottom_ack,
> .irq_compose_msi_msg = dw_pci_setup_msi_msg,
> - .irq_set_affinity = dw_pci_msi_set_affinity,
> + .irq_set_affinity = irq_chip_set_affinity_parent,
> .irq_mask = dw_pci_bottom_mask,
> .irq_unmask = dw_pci_bottom_unmask,
> };
>

Unfortunately, this still crashes ...

[ 11.521674] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000018
[ 11.530324] Mem abort info:
[ 11.533089] ESR = 0x96000004
[ 11.536105] EC = 0x25: DABT (current EL), IL = 32 bits
[ 11.541333] SET = 0, FnV = 0
[ 11.544344] EA = 0, S1PTW = 0
[ 11.547441] Data abort info:
[ 11.550279] ISV = 0, ISS = 0x00000004
[ 11.554056] CM = 0, WnR = 0
[ 11.557007] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000467341000
[ 11.563333] [0000000000000018] pgd=0000000000000000, p4d=0000000000000000
[ 11.570024] Internal error: Oops: 96000004 [#1] PREEMPT SMP
[ 11.575517] Modules linked in: crct10dif_ce pwm_tegra snd_hda_core phy_tegra194_p2u lm90 pcie_tegra194 tegra_bpmp_thermal pwm_fan ip_tables x_tables ipv6
[ 11.589046] CPU: 3 PID: 148 Comm: kworker/3:1 Not tainted 5.9.0-rc4-00009-g6fdf18edb995-dirty #7
[ 11.597669] Hardware name: NVIDIA Jetson AGX Xavier Developer Kit (DT)
[ 11.604110] Workqueue: events deferred_probe_work_func
[ 11.609174] pstate: 60c00089 (nZCv daIf +PAN +UAO BTYPE=--)
[ 11.614657] pc : irq_chip_set_affinity_parent+0x4/0x30
[ 11.619735] lr : msi_domain_set_affinity+0x44/0xc0
[ 11.624448] sp : ffff800012d4b390
[ 11.627744] x29: ffff800012d4b390 x28: ffff0003e7234c20
[ 11.632983] x27: ffff0003e913e460 x26: 0000000000000000
[ 11.638231] x25: ffff800011d7e890 x24: ffff800011d7e8b8
[ 11.643466] x23: 0000000000000000 x22: ffff0003e913e400
[ 11.648701] x21: ffff0003e913e460 x20: ffff0003e913e460
[ 11.653932] x19: ffff800011b19000 x18: ffffffffffffffff
[ 11.659160] x17: 0000000000000000 x16: 0000000000000000
[ 11.664390] x15: 0000000000000001 x14: 0000000000000040
[ 11.669636] x13: 0000000000000228 x12: 0000000000000030
[ 11.674864] x11: 0101010101010101 x10: 0000000000000040
[ 11.680111] x9 : 0000000000000000 x8 : 0000000000000004
[ 11.685363] x7 : ffffffffffffffff x6 : 00000000000000ff
[ 11.690596] x5 : 0000000000000000 x4 : 0000000000000000
[ 11.695843] x3 : ffff8000100d89a8 x2 : 0000000000000000
[ 11.701058] x1 : ffff800011d7e8d8 x0 : 0000000000000000
[ 11.706288] Call trace:
[ 11.708708] irq_chip_set_affinity_parent+0x4/0x30
[ 11.713431] irq_do_set_affinity+0x4c/0x178
[ 11.717540] irq_setup_affinity+0x124/0x1b0
[ 11.721650] irq_startup+0x6c/0x118
[ 11.725081] __setup_irq+0x810/0x8a0
[ 11.728580] request_threaded_irq+0xdc/0x188
[ 11.732793] pcie_pme_probe+0x98/0x110
[ 11.736481] pcie_port_probe_service+0x34/0x60
[ 11.740848] really_probe+0x110/0x400
[ 11.744445] driver_probe_device+0x54/0xb8
[ 11.748482] __device_attach_driver+0x90/0xc0
[ 11.752758] bus_for_each_drv+0x70/0xc8
[ 11.756526] __device_attach+0xec/0x150
[ 11.760306] device_initial_probe+0x10/0x18
[ 11.764413] bus_probe_device+0x94/0xa0
[ 11.768203] device_add+0x464/0x730
[ 11.771630] device_register+0x1c/0x28
[ 11.775311] pcie_port_device_register+0x2d0/0x3e8
[ 11.780017] pcie_portdrv_probe+0x34/0xd8
[ 11.783957] local_pci_probe+0x3c/0xa0
[ 11.787647] pci_device_probe+0x128/0x1c8
[ 11.791588] really_probe+0x110/0x400
[ 11.795179] driver_probe_device+0x54/0xb8
[ 11.799202] __device_attach_driver+0x90/0xc0
[ 11.803480] bus_for_each_drv+0x70/0xc8
[ 11.807244] __device_attach+0xec/0x150
[ 11.811009] device_attach+0x10/0x18
[ 11.814518] pci_bus_add_device+0x4c/0xb0
[ 11.818456] pci_bus_add_devices+0x44/0x90
[ 11.822478] dw_pcie_host_init+0x370/0x4f8
[ 11.826504] tegra_pcie_dw_probe+0x5e8/0xb50 [pcie_tegra194]
[ 11.832044] platform_drv_probe+0x50/0xa8
[ 11.835984] really_probe+0x110/0x400
[ 11.839580] driver_probe_device+0x54/0xb8
[ 11.843608] __device_attach_driver+0x90/0xc0
[ 11.847887] bus_for_each_drv+0x70/0xc8
[ 11.851655] __device_attach+0xec/0x150
[ 11.855424] device_initial_probe+0x10/0x18
[ 11.859548] bus_probe_device+0x94/0xa0
[ 11.863317] deferred_probe_work_func+0x6c/0xa0
[ 11.867781] process_one_work+0x1cc/0x360
[ 11.871720] worker_thread+0x48/0x450
[ 11.875318] kthread+0x120/0x150
[ 11.878495] ret_from_fork+0x10/0x1c
[ 11.882027] Code: a8c17bfd d65f03c0 d503201f f9401400 (f9400c03)

Cheers
Jon

--
nvpublic