From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9415EC4338F for ; Wed, 11 Aug 2021 06:22:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A6C860F55 for ; Wed, 11 Aug 2021 06:22:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234674AbhHKGW4 (ORCPT ); Wed, 11 Aug 2021 02:22:56 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:33384 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234609AbhHKGW4 (ORCPT ); Wed, 11 Aug 2021 02:22:56 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id BAF201C0B76; Wed, 11 Aug 2021 08:22:31 +0200 (CEST) Date: Wed, 11 Aug 2021 08:22:31 +0200 From: Pavel Machek To: Tony Lindgren Cc: linux-omap@vger.kernel.org, Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Grygorii Strashko , Keerthy , Nishanth Menon , Suman Anna , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Pavel Machek , Jarkko Nikula Subject: Re: [PATCH] bus: ti-sysc: Fix error handling for sysc_check_active_timer() Message-ID: <20210811062231.GA16241@duo.ucw.cz> References: <20210811061053.32081-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: <20210811061053.32081-1-tony@atomide.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2021-08-11 09:10:53, Tony Lindgren wrote: > We have changed the return type for sysc_check_active_timer() from -EBUSY > to -ENXIO, but the gpt12 system timer fix still checks for -EBUSY. We are > also not returning on other errors like we did earlier as noted by > Pavel Machek . >=20 > Commit 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with > reserved status") should have been updated for commit 65fb73676112 > ("bus: ti-sysc: suppress err msg for timers used as clockevent/source"). >=20 > Let's fix the issue by checking for -ENXIO and returning on any other > errors as suggested by Pavel Machek . >=20 > Fixes: 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with res= erved status") > Depends-on: 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used= as clockevent/source") > Reported-by: Pavel Machek > Cc: Grygorii Strashko > Cc: Jarkko Nikula > Signed-off-by: Tony Lindgren Reviewed-by: Pavel Machek (CIP) Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYRNspwAKCRAw5/Bqldv6 8s23AJ9BjLJOmtII04M5RH+LmjUDyQSyogCeJrgFXvRYcUo8RUS9OXm9t6cmozA= =WWdc -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--