Re: [PATCH 03/40] dt-bindings: touchscreen: ti,am3359-tsc: New yaml description

Miquel Raynal
2021-09-01T07:42:56Z

Hi Rob,

> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> I prefer that MFDs have just 1 complete example in the MFD schema.

Just to be on the same line, you ask me to drop the all the lines from

tscadc:

up to

dma-names = ...;

and keep only the tsc node, right?

I guess I should do the same in the ADC binding then.

>
> > +
> > + tscadc: tscadc@0 {
>
> Drop unused labels.
>
> > + compatible = "ti,am3359-tscadc";
> > + reg = <0x0 0x1000>;
> > + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&adc_tsc_fck>;
> > + clock-names = "fck";
> > + status = "disabled";
>
> status, again.
>
> > + dmas = <&edma 53 0>, <&edma 57 0>;
> > + dma-names = "fifo0", "fifo1";
> > +
> > + tsc {
> > + compatible = "ti,am3359-tsc";
> > + ti,wires = <4>;
> > + ti,x-plate-resistance = <200>;
> > + ti,coordinate-readouts = <5>;
> > + ti,wire-config = <0x00 0x11 0x22 0x33>;
> > + ti,charge-delay = <0x400>;
> > + };
> > + };
> > --
> > 2.27.0
> >
> >

Thanks,
Miquèl