Re: [PATCH 04/40] dt-bindings: iio: adc: ti,am3359-adc: New yaml description

Jonathan Cameron
2021-08-30T12:28:31Z

On Wed, 25 Aug 2021 17:24:42 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> This ADC was already described in a text file also containing an MFD
> description an a touchscreen description:
> Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> Let's add a proper description for this hardware.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Hi Miquel,

We'd do this different today, but this seems to be an accurate conversion
of what we have. I'll assume this series may well go via mfd, so

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> .../bindings/iio/adc/ti,am3359-adc.yaml | 81 +++++++++++++++++++
> 1 file changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,am3359-adc.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,am3359-adc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,am3359-adc.yaml
> new file mode 100644
> index 000000000000..85d9d642dc67
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,am3359-adc.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,am3359-adc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI AM3359 ADC
> +
> +maintainers:
> + - Miquel Raynal <miquel.raynal@bootlin.com>
> +
> +properties:
> + compatible:
> + const: ti,am3359-adc
> +
> + '#io-channel-cells':
> + const: 1
> +
> + ti,adc-channels:
> + description: List of analog inputs available for ADC. AIN0 = 0, AIN1 = 1 and
> + so on untill AIN7 = 7.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 8
> +
> + ti,chan-step-opendelay:
> + description: List of open delays for each channel of ADC in the order of
> + ti,adc-channels. The value corresponds to the number of ADC clock cycles
> + to wait after applying the step configuration registers and before sending
> + the start of ADC conversion. Maximum value is 0x3FFFF.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 8
> +
> + ti,chan-step-sampledelay:
> + description: List of sample delays for each channel of ADC in the order of
> + ti,adc-channels. The value corresponds to the number of ADC clock cycles
> + to sample (to hold start of conversion high). Maximum value is 0xFF.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 8
> +
> + ti,chan-step-avg:
> + description: Number of averages to be performed for each channel of ADC. If
> + average is 16 (this is also the maximum) then input is sampled 16 times
> + and averaged to get more accurate value. This increases the time taken by
> + ADC to generate a sample. Maximum value is 16.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 8
> +
> +required:
> + - compatible
> + - '#io-channel-cells'
> + - ti,adc-channels
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + tscadc: tscadc@0 {
> + compatible = "ti,am3359-tscadc";
> + reg = <0x0 0x1000>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&adc_tsc_fck>;
> + clock-names = "fck";
> + status = "disabled";
> + dmas = <&edma 53 0>, <&edma 57 0>;
> + dma-names = "fifo0", "fifo1";
> +
> + adc {
> + compatible = "ti,am3359-adc";
> + #io-channel-cells = <1>;
> + ti,adc-channels = <4 5 6 7>;
> + ti,chan-step-opendelay = <0x098 0x3ffff 0x098 0x0>;
> + ti,chan-step-sampledelay = <0xff 0x0 0xf 0x0>;
> + ti,chan-step-avg = <16 2 4 8>;
> + };
> + };