From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DAA2C433EF for ; Thu, 31 Mar 2022 21:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240570AbiCaWAN (ORCPT ); Thu, 31 Mar 2022 18:00:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242185AbiCaWAM (ORCPT ); Thu, 31 Mar 2022 18:00:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61664C30; Thu, 31 Mar 2022 14:58:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59C2CB82256; Thu, 31 Mar 2022 21:58:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F11BEC340F0; Thu, 31 Mar 2022 21:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648763899; bh=EdyYRv/RjH6voZpfK9AsnGWVtEgWXeOuukdtRC5UEKg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=lnycOEjlNdrSNQz4HWAciAAwYkiads1HaoBhzmckHhiGEx2FVc8VApvNG/U9fZnlr 7/clOK8vr/mk4bbIw/imRUg8mKlFLGoy3cP6lF6pfy8pQFAN9CSbTGH1aF7rXWFAwC 5eUCCuB8MPWi+ft9NaYXhMPh7WIgoijxWXzG3EvDuKREPSLVRmVUmawgEWVWzGnPN6 jdqsO4KjIYszy0jIQDN2bn/8Iq5wsP06a7Dx2wzyA5cDIyvc9MJaYk0dnifJpTE+yM 7DMl4xqMVdY5x0jyrH5A50uRGYv52Ykkt6t2QK5+3Hwm5mVrzYernar930y/vMNyzw Uhg6D24iOoTWQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20220325161144.1901695-1-maxime@cerno.tech> <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220331095456.dyyxsiu2b3yw2vvs@houat> <20220331153134.h3alp24hzquajkly@houat> Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put From: Stephen Boyd Cc: Marek Szyprowski , Mike Turquette , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Maxime Ripard , Tony Lindgren Date: Thu, 31 Mar 2022 14:58:17 -0700 User-Agent: alot/0.10 Message-Id: <20220331215818.F11BEC340F0@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Quoting Tony Lindgren (2022-03-31 10:00:09) > * Maxime Ripard [220331 15:29]: > > On Thu, Mar 31, 2022 at 06:00:42PM +0300, Tony Lindgren wrote: > > > * Maxime Ripard [220331 09:52]: > > > > On Thu, Mar 31, 2022 at 12:42:10PM +0300, Tony Lindgren wrote: > > > > > It seems the dts assigned-clock-parents no longer works now? > > > >=20 > > > > That would make some kind of sense, __set_clk_parents calls clk_put= on > > > > both the assigned clock and its parent. > > > >=20 > > > > Could you see what parent (and why?) it tries to enforce then? > > >=20 > > > It picks the other option available for the mux clock that only has > > > two options. No idea why, but if you have some debug patch in mind I > > > can give it a try. > > >=20 > > > > It looks like the gpt1_fck driver might favor another parent for th= at > > > > rate, which, if it's an invalid configuration, shouldn't really hap= pen? > > >=20 > > > Hmm there's a gate clock and a mux clock, there's not really a rate > > > selection available here for the sources. > >=20 > > If I followed the OMAP driver properly, clk_mux_determine_rate_flags is > > doing the heavy lifting, could you run your test with >=20 > Thanks that produces some interesting output. In the working case with > the $subject patch reverted we have: I don't think clk_put() dropping a range request is very important right now. If this isn't fixed tomorrow then we should revert out this patch so systems can boot -rc1 and try to fix it in parallel.