* [PATCH] clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe
@ 2022-06-02 3:08 Miaoqian Lin
2022-06-28 5:20 ` Tony Lindgren
2022-10-01 0:40 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-06-02 3:08 UTC (permalink / raw)
To: Tero Kristo, Michael Turquette, Stephen Boyd, Tony Lindgren,
Miaoqian Lin, Peter Ujfalusi, linux-omap, linux-clk, linux-kernel
pm_runtime_get_sync() will increment pm usage counter.
Forgetting to putting operation will result in reference leak.
Add missing pm_runtime_put_sync in some error paths.
Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/clk/ti/clk-dra7-atl.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index aa0950c4f498..5c278d6c985e 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -253,14 +253,16 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
if (rc) {
pr_err("%s: failed to lookup atl clock %d\n", __func__,
i);
- return -EINVAL;
+ ret = -EINVAL;
+ goto pm_put;
}
clk = of_clk_get_from_provider(&clkspec);
if (IS_ERR(clk)) {
pr_err("%s: failed to get atl clock %d from provider\n",
__func__, i);
- return PTR_ERR(clk);
+ ret = PTR_ERR(clk);
+ goto pm_put;
}
cdesc = to_atl_desc(__clk_get_hw(clk));
@@ -293,8 +295,9 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
if (cdesc->enabled)
atl_clk_enable(__clk_get_hw(clk));
}
- pm_runtime_put_sync(cinfo->dev);
+pm_put:
+ pm_runtime_put_sync(cinfo->dev);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe
2022-06-02 3:08 [PATCH] clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe Miaoqian Lin
@ 2022-06-28 5:20 ` Tony Lindgren
2022-10-01 0:40 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2022-06-28 5:20 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Tero Kristo, Michael Turquette, Stephen Boyd, Peter Ujfalusi,
linux-omap, linux-clk, linux-kernel
* Miaoqian Lin <linmq006@gmail.com> [220602 06:04]:
> pm_runtime_get_sync() will increment pm usage counter.
> Forgetting to putting operation will result in reference leak.
> Add missing pm_runtime_put_sync in some error paths.
>
> Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe
2022-06-02 3:08 [PATCH] clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe Miaoqian Lin
2022-06-28 5:20 ` Tony Lindgren
@ 2022-10-01 0:40 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2022-10-01 0:40 UTC (permalink / raw)
To: Miaoqian Lin, Michael Turquette, Peter Ujfalusi, Tero Kristo,
Tony Lindgren, linux-clk, linux-kernel, linux-omap
Quoting Miaoqian Lin (2022-06-01 20:08:36)
> pm_runtime_get_sync() will increment pm usage counter.
> Forgetting to putting operation will result in reference leak.
> Add missing pm_runtime_put_sync in some error paths.
>
> Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-01 0:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-02 3:08 [PATCH] clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe Miaoqian Lin
2022-06-28 5:20 ` Tony Lindgren
2022-10-01 0:40 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).