From: Yang Li <yang.lee@linux.alibaba.com>
To: tony@atomide.com
Cc: lgirdwood@gmail.com, broonie@kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH -next] regulator: drivers: Remove unnecessary print function dev_err()
Date: Thu, 25 Aug 2022 15:04:38 +0800 [thread overview]
Message-ID: <20220825070438.128093-1-yang.lee@linux.alibaba.com> (raw)
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1986
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/regulator/tps65219-regulator.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c
index 7ba2594e437c..ab16e6665625 100644
--- a/drivers/regulator/tps65219-regulator.c
+++ b/drivers/regulator/tps65219-regulator.c
@@ -363,11 +363,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev)
irq_type = &tps65219_regulator_irq_types[i];
irq = platform_get_irq_byname(pdev, irq_type->irq_name);
- if (irq < 0) {
- dev_err(tps->dev, "Failed to get IRQ %s: %d\n",
- irq_type->irq_name, irq);
+ if (irq < 0)
return -EINVAL;
- }
+
irq_data[i].dev = tps->dev;
irq_data[i].type = irq_type;
--
2.20.1.7.g153144c
next reply other threads:[~2022-08-25 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 7:04 Yang Li [this message]
2022-08-25 13:09 ` [PATCH -next] regulator: drivers: Remove unnecessary print function dev_err() Mark Brown
2022-08-26 6:10 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825070438.128093-1-yang.lee@linux.alibaba.com \
--to=yang.lee@linux.alibaba.com \
--cc=abaci@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox