Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s)

Kent Gibson
2022-10-11T00:02:07Z

On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote:
> Do not imply that some of the generic headers may be always included.
> Instead, include explicitly what we are direct user of.
>
> While at it, sort headers alphabetically.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpiolib-cdev.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index f8041d4898d1..60a60e2d60c5 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -10,8 +10,9 @@
> #include <linux/device.h>
> #include <linux/err.h>
> #include <linux/file.h>
> -#include <linux/gpio.h>
> #include <linux/gpio/driver.h>
> +#include <linux/gpio.h>
> +#include <linux/hte.h>

Ok with the hte re-order.

But moving the gpio subsystem header after the gpio/driver is not
alphabetical ('.' precedes '/') and it read better and made more sense
to me the way it was.

> #include <linux/interrupt.h>
> #include <linux/irqreturn.h>
> #include <linux/kernel.h>
> @@ -20,11 +21,12 @@
> #include <linux/mutex.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/poll.h>
> +#include <linux/seq_file.h>

I wasn't aware that we use anything from seq_file.
What am I missing?

Cheers,
Kent.

> #include <linux/spinlock.h>
> #include <linux/timekeeping.h>
> #include <linux/uaccess.h>
> #include <linux/workqueue.h>
> -#include <linux/hte.h>
> +
> #include <uapi/linux/gpio.h>
>
> #include "gpiolib.h"
> --
> 2.35.1
>