Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s)

Kent Gibson
2022-10-11T14:13:16Z

On Tue, Oct 11, 2022 at 04:48:17PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 11, 2022 at 11:05:42AM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 11, 2022 at 3:02 AM Kent Gibson <warthog618@gmail.com> wrote:
> > > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > > > -#include <linux/gpio.h>
> > > > #include <linux/gpio/driver.h>
> > > > +#include <linux/gpio.h>
> > > > +#include <linux/hte.h>
> > >
> > > Ok with the hte re-order.
> > >
> > > But moving the gpio subsystem header after the gpio/driver is not
> > > alphabetical ('.' precedes '/') and it read better and made more sense
> > > to me the way it was.
> >
> > I see, I guess this is vim sort vs shell sort. Strange, they should
> > follow the locale settings...
>
> I have checked, the shell and vim sort gave the same result as in this patch.
>

The original order (sans hte.h) was done by VSCode Sort Lines Ascending,
and that still returns the same result. That matches what I would
expect to see given the content of the text.

And for me vim also gives the original order.

Just to confirm - is '.' 0x2e and '/' 0x2f in your universe?

Cheers,
Kent.