Re: [PATCH v2 36/36] pinctrl: Clean up headers

Andy Shevchenko
2022-10-11T09:05:15Z

On Tue, Oct 11, 2022 at 01:00:11PM +0530, Basavaraj Natikar wrote:
> On 10/11/2022 1:44 AM, Andy Shevchenko wrote:

...

> > --- a/drivers/pinctrl/core.h
> > +++ b/drivers/pinctrl/core.h

> > -#include <linux/pinctrl/pinconf.h>
>
> Removing pinconf.h from the core.h may cause build failure in other files
> because where-ever core.h is included to use “struct pinconf_ops”, there
> is a need to include pinconf.h.

Yes, I compiled only few drivers with the core changes. Still I got a few
reports by LKP. Thank you for spotting this!

> With that fixed,
>
> Reviewed-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

Thank you!

--
With Best Regards,
Andy Shevchenko