From: Stephen Boyd <sboyd@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: Amarula patchwork <linux-amarula@amarulasolutions.com>,
michael@amarulasolutions.com,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
kernel test robot <lkp@intel.com>,
Allison Randal <allison@lohutok.net>,
Miaoqian Lin <linmq006@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Tero Kristo <kristo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Lindgren <tony@atomide.com>,
linux-clk@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] clk: ti: dra7-atl: don't allocate `parent_names' variable
Date: Thu, 27 Oct 2022 17:27:08 -0700 [thread overview]
Message-ID: <20221028002710.89A81C43470@smtp.kernel.org> (raw)
In-Reply-To: <20221018160352.1591428-1-dario.binacchi@amarulasolutions.com>
Quoting Dario Binacchi (2022-10-18 09:03:52)
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index ff4d6a951681..78482d1a4a33 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -188,24 +188,17 @@ static void __init of_dra7_atl_clock_setup(struct device_node *node)
> goto cleanup;
> }
>
> - parent_names = kzalloc(sizeof(char *), GFP_KERNEL);
> -
> - if (!parent_names)
> - goto cleanup;
> -
> parent_names[0] = of_clk_get_parent_name(node, 0);
Can you use struct clk_parent_data instead and assign index to 0? Then
we don't even need to use of_clk_get_parent_name() here.
next prev parent reply other threads:[~2022-10-28 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 16:03 [PATCH v2] clk: ti: dra7-atl: don't allocate `parent_names' variable Dario Binacchi
2022-10-28 0:27 ` Stephen Boyd [this message]
2022-10-30 13:00 ` Dario Binacchi
2022-11-01 18:35 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028002710.89A81C43470@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=allison@lohutok.net \
--cc=dario.binacchi@amarulasolutions.com \
--cc=kristo@kernel.org \
--cc=linmq006@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox